Skip to content

fix(oauth): instance name encoding on oauth app in admin#49804

Open
byt3sage wants to merge 46 commits intonextcloud:masterfrom
byt3sage:bug/oauth-instance-name-decoding-39956
Open

fix(oauth): instance name encoding on oauth app in admin#49804
byt3sage wants to merge 46 commits intonextcloud:masterfrom
byt3sage:bug/oauth-instance-name-decoding-39956

Conversation

@byt3sage
Copy link
Copy Markdown

@byt3sage byt3sage commented Dec 11, 2024

Summary

  • This PR aims to resolve the issue with the encoding of the instance name when shown in the OAuth settings in Nextcloud admin.
  • This is my first PR for Nextcloud (and hopefully the first of many) so I'm keen for any feedback if this approach doesn't follow what it should.
  • I've removed instance name from the translate function. My reasoning for this is the instance name will already be in the users own language and this avoids the issue of the translate function escaping special characters.

TODO

  • Remove instance name binding from the translate function and use string interpolation instead.
  • Update translation files to ensure the string prior to the instance name is still translated.

Screenshots

Before
image

After
image

Checklist

@byt3sage
bug: moved instance name out of l10n to fix issue with instance name …
02a6eb4 
…decoding

Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@byt3sage
chore: formatting
91a399e 
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@byt3sage byt3sage mentioned this pull request Dec 11, 2024
Open
8 tasks
@kesselb
Copy link
Copy Markdown
Contributor

kesselb commented Dec 12, 2024

Thanks for your pull request 👍

Please revert the changes to the language files. The files are synced automatically from Transifex. It's enough to change the source.

@byt3sage
Copy link
Copy Markdown
Author

byt3sage commented Dec 13, 2024

@kesselb Ah that makes sense! I've reverted these back now.

byt3sage and others added 23 commits December 13, 2024 09:14
@byt3sage
Merge branch 'master' of github.com:byt3sage/server into bug/oauth-in…
4c57f0b 
…stance-name-decoding-39956
@byt3sage
Merge branch 'bug/oauth-instance-name-decoding-39956' of github.com:b…
8bfe048 
…yt3sage/server into bug/oauth-instance-name-decoding-39956
@byt3sage
Merge branch 'master' into bug/oauth-instance-name-decoding-39956
ce6e450
@byt3sage
Merge branch 'bug/oauth-instance-name-decoding-39956' of github.com:b…
4cd8a48 
…yt3sage/server into bug/oauth-instance-name-decoding-39956

Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@byt3sage
Merge branch 'bug/oauth-instance-name-decoding-39956' of github.com:b…
7a9eb28 
…yt3sage/server into bug/oauth-instance-name-decoding-39956
@byt3sage
chore: formatting
d766b71 
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@byt3sage
chore: reverted language files
f259cbc 
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@Koc @byt3sage
fix: Fix ServiceWorker scope when Nextcloud installed in subfolder
4f8eec1 
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@nextcloud-command @byt3sage
chore(assets): Recompile assets
6ce16a9 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@icewind1991 @byt3sage
chore: cleanup leftover debug statement
f4993a6 
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@skjnldsv @byt3sage
fix(files): throttle favorite with max 5 simultaneous requests
ab6bd5e 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@nextcloud-command @byt3sage
chore(assets): Recompile assets
7d2508a 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@nfebe @byt3sage
fix(files_sharing): Correct property enforced property names
810a5bc 
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@nextcloud-command @byt3sage
chore(assets): Recompile assets
1ac6a3a 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@nextcloud-bot @byt3sage
Fix(l10n): Update translations from Transifex
f37a39c 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@skjnldsv @byt3sage
fix(files_sharing): also submit new share on password submit
0f464f8 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@nextcloud-command @byt3sage
chore(assets): Recompile assets
9687bb8 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@grnd-alt @byt3sage
fix(dav): add activity logging for favorites in dav
1690451 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@grnd-alt @byt3sage
refactor(tags): move favorite event dispatching to tags.php
9e18dbd 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@grnd-alt @byt3sage
fix(tests): remove redundant unit test for activity
0443c66 
Signed-off-by: grnd-alt <github@belakkaf.net>
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@come-nc @byt3sage
fix(files_sharing): Do not wrap password policy exception into a gene…
931eb36 
…ric one

Let the controller access the HintException and show the error to the user.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@come-nc @byt3sage
fix(shares): Wrap exceptions from password validation to set code to 400
a230b74 
This fixes a regression that bad password returned 403 instead of 400
 because of previous changes.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@come-nc @byt3sage
fix(tests): Adapt ManagerTest to change in Exception class used
fe8c429 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: byt3sage <jjt@tfmail.co.uk>
@kesselb
Copy link
Copy Markdown
Contributor

kesselb commented Dec 27, 2024

cc @julien-nc

@kesselb
Copy link
Copy Markdown
Contributor

kesselb commented Dec 27, 2024

Hi @byt3sage

Thank you, it appears that the last rebase went wrong. Could you please retry?

@susnux susnux added this to the Nextcloud 32 milestone Mar 2, 2025
This was referenced Aug 22, 2025
Merged
Merged
Merged
This was referenced Sep 2, 2025
Merged
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 10, 2025
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 18, 2025
Merged
This was referenced Sep 25, 2025
Merged
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
This was referenced Jan 7, 2026
Merged
Merged
This was referenced Jan 14, 2026
Merged
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 22, 2026
Merged
This was referenced Jan 29, 2026
Merged
Merged
This was referenced Feb 11, 2026
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 33, Nextcloud 34 Feb 16, 2026
@DorraJaouad DorraJaouad requested a review from a team as a code owner April 23, 2026 09:41
@DorraJaouad DorraJaouad requested review from nfebe, sorbaugh and szaimen and removed request for a team April 23, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@szaimen szaimen Awaiting requested review from szaimen szaimen is a code owner automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

feedback-requested

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

[Bug]: Instance name not decoded in the "OAuth 2.0-Clients" config menu