fix(settings): Deprecate old things for real#43581
Merged
nickvergessen merged 3 commits intomasterfrom Feb 14, 2024
Merged
Conversation
bigcat88
approved these changes
Feb 14, 2024
blizzz
approved these changes
Feb 14, 2024
Member
blizzz
left a comment
There was a problem hiding this comment.
not sure why commented out code was committed
AndyScherzinger
approved these changes
Feb 14, 2024
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
a98078b to
42be7a5
Compare
st3iny
approved these changes
Feb 14, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Psalm output before:
Follow up
@sincefor constants in OCP => Follow up PR as there are 223 failures 😱Checklist