feat(UserMenu): add target property to usermenu component#41659
feat(UserMenu): add target property to usermenu component#41659fitrahmunir wants to merge 2 commits intonextcloud:masterfrom
Conversation
4d9756b to
fb009e9
Compare
|
I don't think the admin settings should open in a new tab all the time? cc @nextcloud/designers |
fb009e9 to
c9d4e40
Compare
|
This is an old one.. I agree with the proposed change. I think that admin settings and personal settings, and all apps for that matter, should open in another tab. This solution:
So by insisting on loading different things in the same tab in pursuit of the big single page application feel, we're effectively discouraging users from using the multitasking feature that comes with a web browser. @nextcloud/designers please go and take a look at other (multi-app) projects, the usual suspects. All of them open apps and global settings in new tabs, despite the fact that their loading times are in general faster than ours. (Testing their loading times vs. my local docker loading times). |
|
Hm... I think I don't like this idea. New tabs usually should only be opened for links to external services or if it is really necessary IIRC... |
That is just a convention that seems to be born out of not wanting users to navigate away from your site. Not a UX rule. As per the necessity of it, I think here it's warranted because of the reasons I mentioned above. And our friends at G & M, that have all the UX research resources that they want, reached that conclusion too. |
Fine by me then 👍 |
c9d4e40 to
c7a9d02
Compare
6ad0f1b to
5962797
Compare
5962797 to
7f0aed1
Compare
|
@nickvergessen please review this PR |
ebc2167 to
ce22dcc
Compare
…ponent Signed-off-by: Fitrah Munir <fitrahmunir@outlook.com>
come-nc
left a comment
There was a problem hiding this comment.
👎 I do not think this is a good idea. It forces the user to open those pages in new tabs while it’s usually not what I want.
See https://sensiolabs.com/blog/2025/the-tab-trap-why-forcing-new-tabs-is-bad-ux for why this is a bad practice.
|
I agree with szaimen and come-nc. If a user wants to open admin settings in a new tab, the user can user CTRL+Click, middle mouse button click, or the context menu while the default is opening in the current tab. We do not prevent the choice here. If we change the default, keeping it open in the same tab is not so straightforward, and we are giving no choice to the user. Especially if a user initially opened the instance to navigate to the admin settings. |
|
Maybe it was changed in the meanwhile, but the linked issue seems about a different problem. |
|
@fitrahmunir thank you very much for your contribution! |

Summary
Add target property to UserMenu and UserMenuEntry components and add target "_blank" to Administration settings
TODO
Checklist