Skip to content

fix safari useragent for versions with 3 digits#19954

Merged
rullzer merged 1 commit intonextcloud:masterfrom
roscomputing:fix/19941/fix_safari_useragent
Mar 15, 2020
Merged

fix safari useragent for versions with 3 digits#19954
rullzer merged 1 commit intonextcloud:masterfrom
roscomputing:fix/19941/fix_safari_useragent

Conversation

@xklonx
Copy link
Copy Markdown
Contributor

@xklonx xklonx commented Mar 14, 2020 •
edited by kesselb
Loading

Fix #19941

@xklonx
fix safari useragent for versions with 3 digits
f11dee9 
Signed-off-by: Pavel Krasikov <klonishe@gmail.com>
@xklonx xklonx mentioned this pull request Mar 14, 2020
Closed
@kesselb
Copy link
Copy Markdown
Contributor

kesselb commented Mar 14, 2020

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0 Safari/605.1.15

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_3) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0.5 Safari/605.1.15

As per https://developers.whatismybrowser.com/useragents/explore/software_name/safari/ both are valid.

@kesselb kesselb added 3. to review Waiting for reviews bug labels Mar 14, 2020
@kesselb kesselb added this to the Nextcloud 19 milestone Mar 14, 2020
@kesselb
Copy link
Copy Markdown
Contributor

kesselb commented Mar 14, 2020

/backport to stable18

@rullzer rullzer merged commit 0ffa598 into nextcloud:master Mar 15, 2020
@welcome
Copy link
Copy Markdown

welcome Bot commented Mar 15, 2020

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@backportbot-nextcloud backportbot-nextcloud Bot mentioned this pull request Mar 15, 2020
Merged
@backportbot-nextcloud
Copy link
Copy Markdown

backportbot-nextcloud Bot commented Mar 15, 2020

backport to stable18 in #19966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@kesselb kesselb kesselb approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

Wrong useragent regex for safari in browserSupportsCspV3

3 participants

@xklonx @kesselb @rullzer