Cleanup OC_JSON usage

[rullzer]

OCP\JSON removed, only OC_JSON todo

---

Since this is deprecated API we should really get rid of it sooner rather than later! Especially since it returns invalid status codes for errors (200 usually).

For checkedLoggedIn:

• files_version:

  • server/apps/files_trashbin/ajax/delete.php

    Line 27 in 0215b00

    OCP\JSON::checkLoggedIn();

  • server/apps/files_versions/download.php

    Line 29 in 70b1f51

    OCP\JSON::checkLoggedIn();

  • server/apps/files_versions/ajax/getVersions.php

    Line 27 in 813f0a0

    OCP\JSON::checkLoggedIn();

  • server/apps/files_trashbin/ajax/list.php

    Line 24 in 813f0a0

    OCP\JSON::checkLoggedIn();

  • server/apps/files_versions/ajax/rollbackVersion.php

    Line 29 in 0215b00

    OCP\JSON::checkLoggedIn();

• files_trashbin:

  • server/apps/files_trashbin/ajax/isEmpty.php

    Line 25 in 813f0a0

    OCP\JSON::checkLoggedIn();

  • server/apps/files_trashbin/ajax/undelete.php

    Line 29 in 0eebff1

    OCP\JSON::checkLoggedIn();

• files_external:

  • server/apps/files_external/ajax/oauth2.php

    Line 26 in 0eebff1

    OCP\JSON::checkLoggedIn();

• files:

  • server/apps/files/ajax/getstoragestats.php

    Line 32 in 0215b00

    OCP\JSON::checkLoggedIn();

  • server/apps/files/ajax/list.php

    Line 30 in eb51f06

    OCP\JSON::checkLoggedIn();

• core

  • server/core/search/ajax/search.php

    Line 29 in 0215b00

    \OCP\JSON::checkLoggedIn();

There is probably more I missed but this is a good start to cleanup.

[MorrisJobke]

@schiessle as we talked about trashbin and versions ;)

[juliusknorr]

• settings/ajax/* uses a lot of OCP\JSON and OC_JSON as well
  • for apps management this will be addressed in Move endpoints to from apps management apps to AppSettingsController #7931

[rullzer]

@MorrisJobke yes versions and trashbin should be cleaned up. But IMO they should get an overhaul anyway,

• Move to a dav endpoint (so web+clients can all use it)
• Move away from all the static code maddness

[szaimen]

I suppose this issue is still valid? If not, please close this issue!

[juliusknorr]

Still valid