Making use of .nginx.containerPort when fpm is enabled#851
Open
Ejdesgaard wants to merge 2 commits intonextcloud:mainfrom
Open
Making use of .nginx.containerPort when fpm is enabled#851Ejdesgaard wants to merge 2 commits intonextcloud:mainfrom
Ejdesgaard wants to merge 2 commits intonextcloud:mainfrom
Conversation
Ejdesgaard
force-pushed
the
fpm-containerPort
branch
2 times, most recently
from
56ee934 to
0cfa833
Compare
Signed-off-by: Heðin Ejdesgaard <hej@ejdesgaard.fo>
Ejdesgaard
force-pushed
the
fpm-containerPort
branch
from
0cfa833 to
cc4bdfa
Compare
Author
|
Sorry for all the force-pushes, I tried to sort out the commit message... |
Signed-off-by: Heðin Ejdesgaard <hej@ejdesgaard.fo>
Ejdesgaard
force-pushed
the
fpm-containerPort
branch
from
6a5f134 to
0d4964a
Compare
Collaborator
|
Why not drop nginx.container port ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows different nginx and fpm ports to be used, by utilizing the
.nginx.containerPort, when fpm is enabled.