Port admin settings to vue#1072
Conversation
|
No worries! |
|
@pReya did you forget to click submit for your review? :) |
pReya
left a comment
There was a problem hiding this comment.
REUSE.toml and .nextcloudignore are still referencing old/deleted file names
Also, the saving semantics are a little inconsistent: The name/url fields are saved on change, while all the settings in the modal, require an explicit "Save" button press. Might be a good idea, to use the same "style" on all fields?
You know me well ;) |
@CarlSchwan Did you see these comments that have no explicit code location? |
Yes, going to handle them, just getting distracted with some other works :) |
Done
It's a pattern we use in a bunch of other apps, where settings are auto-saved unless they are in a dialog where there is an explicit save button. Also since last time, I updated quota-files-sidebar.ts as the previous version sort of worked but looked terribly as the CSS didn't work anymore. |
9b8d2d2 to
3a1e1b6
Compare
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
And fixes graphical issues with dark/light theme and new vue file sidebar Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Make it consistent with external.png and external-dark.png Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
But port it to typescript Signed-off-by: Carl Schwan <carlschwan@kde.org>
Handlebar/jquery ui isn't provided anymore by server