Skip to content

Port admin settings to vue#1072

Merged
CarlSchwan merged 10 commits intomasterfrom
carl/vue
Apr 27, 2026
Merged

Port admin settings to vue#1072
CarlSchwan merged 10 commits intomasterfrom
carl/vue

Conversation

@CarlSchwan
Copy link
Copy Markdown
Member

image

Handlebar/jquery ui isn't provided anymore by server

@CarlSchwan CarlSchwan requested a review from susnux April 23, 2026 16:32
@CarlSchwan CarlSchwan self-assigned this Apr 23, 2026
@provokateurin
Copy link
Copy Markdown
Member

Closes #1067

@pReya wanted to give this a shot. Maybe @pReya you could review this PR then? I'm sorry that someone else already did this before you, it wasn't coordinated well 😓

@CarlSchwan
Copy link
Copy Markdown
Member Author

Closes #1067

@pReya wanted to give this a shot. Maybe @pReya you could review this PR then? I'm sorry that someone else already did this before you, it wasn't coordinated well 😓

Ah I didn't saw the issue. I had a local draft for many months and i just resucited it :/

@provokateurin
Copy link
Copy Markdown
Member

No worries!

@pReya
Copy link
Copy Markdown
Contributor

pReya commented Apr 23, 2026

Closes #1067

@pReya wanted to give this a shot. Maybe @pReya you could review this PR then? I'm sorry that someone else already did this before you, it wasn't coordinated well 😓

No hard feelings. All good. I've added my review.

@CarlSchwan
Copy link
Copy Markdown
Member Author

@pReya did you forget to click submit for your review? :)

Copy link
Copy Markdown
Contributor

@pReya pReya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REUSE.toml and .nextcloudignore are still referencing old/deleted file names

Also, the saving semantics are a little inconsistent: The name/url fields are saved on change, while all the settings in the modal, require an explicit "Save" button press. Might be a good idea, to use the same "style" on all fields?

Comment thread src/AdminSettings.vue
Comment thread src/AdminSettings.vue
@pReya
Copy link
Copy Markdown
Contributor

pReya commented Apr 24, 2026

@pReya did you forget to click submit for your review? :)

You know me well ;)

@pReya
Copy link
Copy Markdown
Contributor

pReya commented Apr 24, 2026

REUSE.toml and .nextcloudignore are still referencing old/deleted file names

Also, the saving semantics are a little inconsistent: The name/url fields are saved on change, while all the settings in the modal, require an explicit "Save" button press. Might be a good idea, to use the same "style" on all fields?

@CarlSchwan Did you see these comments that have no explicit code location?

@CarlSchwan
Copy link
Copy Markdown
Member Author

REUSE.toml and .nextcloudignore are still referencing old/deleted file names
Also, the saving semantics are a little inconsistent: The name/url fields are saved on change, while all the settings in the modal, require an explicit "Save" button press. Might be a good idea, to use the same "style" on all fields?

@CarlSchwan Did you see these comments that have no explicit code location?

Yes, going to handle them, just getting distracted with some other works :)

Comment thread package.json Outdated
@CarlSchwan
Copy link
Copy Markdown
Member Author

REUSE.toml and .nextcloudignore are still referencing old/deleted file names

Done

Also, the saving semantics are a little inconsistent: The name/url fields are saved on change, while all the settings in the modal, require an explicit "Save" button press. Might be a good idea, to use the same "style" on all fields?

It's a pattern we use in a bunch of other apps, where settings are auto-saved unless they are in a dialog where there is an explicit save button.

Also since last time, I updated quota-files-sidebar.ts as the previous version sort of worked but looked terribly as the CSS didn't work anymore.

@CarlSchwan CarlSchwan force-pushed the carl/vue branch 3 times, most recently from 9b8d2d2 to 3a1e1b6 Compare April 27, 2026 10:26
Comment thread docs/page-sample.png
Comment thread src/AdminSettings.vue Outdated
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
And fixes graphical issues with dark/light theme and new vue file
sidebar

Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Make it consistent with external.png and external-dark.png

Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
But port it to typescript

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan CarlSchwan merged commit ed55eb1 into master Apr 27, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants