Skip to content

Add example for pomerium#9232

Merged
skjnldsv merged 3 commits intonextcloud:masterfrom
JeffMatson:patch-2
Apr 23, 2026
Merged

Add example for pomerium#9232
skjnldsv merged 3 commits intonextcloud:masterfrom
JeffMatson:patch-2

Conversation

@JeffMatson
Copy link
Copy Markdown
Contributor

@JeffMatson JeffMatson commented Oct 20, 2022

No description provided.

Signed-off-by: Jeff Matson <jeff@jeffmatson.net>
redirect:
path_redirect: /remote.php/dav/

Thanks to `@JeffMatson <https://github.com/JeffMatson>`_ for Pomerium example.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear I introduce the "Thanks to" pattern with #1297 🙈

The rules were from a GitHub issue, and my motivation was to acknowledge the actual authors.

Copilot AI review requested due to automatic review settings April 23, 2026 09:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new reverse-proxy configuration snippet for Pomerium to the admin manual, alongside existing examples (Apache/Traefik/NGINX/Caddy).

Changes:

  • Add a “Pomerium” section with redirect rules for /.well-known/{carddav,caldav}.
  • Add attribution for the contributed Pomerium example.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

reverse_proxy {$NEXTCLOUD_HOST:localhost}
}


Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 149 is a blank line containing trailing spaces. This can cause whitespace-only diffs and can fail doc/formatting linters; make it a truly empty line (no spaces).

Suggested change

Copilot uses AI. Check for mistakes.

Pomerium
^^^^^^^^
::
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The literal block introduced by "::" should be followed by a blank line before the indented content. As written, the Pomerium snippet starts immediately on the next line, which can break RST rendering; insert an empty line between "::" and the first "- from" line.

Suggested change
::
::

Copilot uses AI. Check for mistakes.
Comment thread admin_manual/configuration_server/reverse_proxy_configuration.rst Outdated
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv enabled auto-merge April 23, 2026 09:36
@skjnldsv skjnldsv merged commit ebfa0a1 into nextcloud:master Apr 23, 2026
21 checks passed
@welcome
Copy link
Copy Markdown

welcome Bot commented Apr 23, 2026

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/documentation/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants