fix: Disabled app list stays empty due to missing diffutils on Alpine #2254
fix: Disabled app list stays empty due to missing diffutils on Alpine #2254Aakash788 wants to merge 1 commit intonextcloud:masterfrom
diffutils on Alpine #2254Conversation
Signed-off-by: Aakash788 <aakashparmar788@gmail.com>
|
Hi @Aakash788 - Thanks! If you can split out that second commit into a separate PR so it could be reviewed separately that would be appreciated (since they're quite different matters). Otherwise it'll block this PR from being reviewed/merged. If it's easier, feel free to submit new PRs. If you create a new local branch for each fix, you can submit the PR from those dedicated branches. That may make your life easier too. :-) |
|
Hi @joshtrichards I've removed the second commit from the current PR. I'll submit it as a separate PR for separate review and thanks for the advice about using dedicated branches for each fix moving forward to keep things organized. |
diffutils on Alpine
|
#1213 suggests to remove the logic altogether. |
Fixes #1911
Description:
This PR fixes issue #1911 by installing
diffutilsin alpine image and made change in theDockerfile-alpine.template. This ensures that the disabled app list is populated correctly.Changes:
Dockerfile-alpine.templateto includediffutilsin alpine docker image.Testing:
Additional Notes: