IResponse: add missing $sameSite parameter to setCookie()#247
Open
jelen07 wants to merge 13 commits into
Open
Conversation
- removed slow getRemoteHost() reverse DNS lookups assertions
- The concrete Response::setCookie() already accepts ?string $sameSite as the 8th parameter, but the IResponse interface is missing it. This makes it impossible to set the SameSite attribute when working with the interface without suppressing static analysis errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dg
force-pushed
the
v3.3
branch
4 times, most recently
from
264bb23 to
d92cb97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Response::setCookie()already accepts?string $sameSiteas the 8th parameter, but theIResponseinterface is missing itargument.unknown)master(4.0) already includes this parameter — this backports it to v3.3Diff
Single line addition:
?string $sameSite = nullas the last parameter ofIResponse::setCookie()This is backwards-compatible since the parameter is optional with a
nulldefault.