Skip to content

Add completion subcommand#53

Merged
nao1215 merged 5 commits intomainfrom
add-completion-cmd
Oct 2, 2022
Merged

Add completion subcommand#53
nao1215 merged 5 commits intomainfrom
add-completion-cmd

Conversation

@nao1215
Copy link
Copy Markdown
Owner

@nao1215 nao1215 commented Oct 2, 2022

This PR is for #28.

There are two problems with the automatic creation of shell completion files:

  1. the creation of shell completion files without the user's permission may cause discomfort to the user
  2. the deletion process is necessary because a shell completion file is created each time the root command is unit tested.

gup is designed to automatically create shell completion files to reduce user work. Therefore, the completion subcommand (default) of the cobra library is not used. Also, PowerShell support will be implemented as soon as possible.

@akimon658
Although you may not already use the original gup, I report to you.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 2, 2022

Codecov Report

Merging #53 (2a6e6a4) into main (82477c7) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   90.43%   90.49%   +0.06%     
==========================================
  Files          11       12       +1     
  Lines         460      463       +3     
==========================================
+ Hits          416      419       +3     
  Misses         28       28              
  Partials       16       16              
Impacted Files Coverage Δ
cmd/root.go 100.00% <ø> (ø)
cmd/completion.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nao1215 nao1215 changed the title Add completion cmd Add completion subcommand Oct 2, 2022
@nao1215 nao1215 merged commit 061f337 into main Oct 2, 2022
@nao1215 nao1215 deleted the add-completion-cmd branch October 2, 2022 14:21
@akimon658
Copy link
Copy Markdown
Contributor

Awesome! I'll use the original gup again as it was not efficient to develop the fork.
Thank you for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants