Skip to content

Add test for gotuil.GetPackageVersion() function#49

Merged
nao1215 merged 1 commit intonao1215:mainfrom
KEINOS:cover-up-tests
Sep 20, 2022
Merged

Add test for gotuil.GetPackageVersion() function#49
nao1215 merged 1 commit intonao1215:mainfrom
KEINOS:cover-up-tests

Conversation

@KEINOS
Copy link
Copy Markdown
Contributor

@KEINOS KEINOS commented Sep 20, 2022

This should bring the coverage back to 100%. Hopefully 🤞

  • Add test for gotuil.GetPackageVersion() function.
  • Modification of the gotuil.GetPackageInformation() function example to make it clearer.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 20, 2022

Codecov Report

Merging #49 (df4536e) into main (ea3d027) will increase coverage by 1.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   87.81%   89.42%   +1.60%     
==========================================
  Files          11       11              
  Lines         435      435              
==========================================
+ Hits          382      389       +7     
+ Misses         39       33       -6     
+ Partials       14       13       -1     
Impacted Files Coverage Δ
internal/goutil/goutil.go 100.00% <0.00%> (+5.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@KEINOS KEINOS marked this pull request as ready for review September 20, 2022 01:50
@nao1215
Copy link
Copy Markdown
Owner

nao1215 commented Sep 20, 2022

@KEINOS
Oops, I merged my previous PR early!
This is clean test code 👍

@nao1215 nao1215 merged commit 84a0627 into nao1215:main Sep 20, 2022
@KEINOS KEINOS deleted the cover-up-tests branch September 20, 2022 03:36
@KEINOS
Copy link
Copy Markdown
Contributor Author

KEINOS commented Sep 20, 2022

@nao1215

Oops, I merged my previous PR early!

Oops! Sorry. Glad that it didn't conflict. Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants