Conversation
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage 84.40% 84.40%
=======================================
Files 10 10
Lines 295 295
=======================================
Hits 249 249
Misses 33 33
Partials 13 13 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Owner
Author
|
Windows... |
1 similar comment
Contributor
|
Windows... |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cmd/remove_test.go
Outdated
| tmpFile, e = os.CreateTemp(t.TempDir(), strings.ReplaceAll(t.Name(), "/", "")) | ||
| } else { | ||
| // See https://github.com/golang/go/issues/51442 | ||
| tmpFile, err = os.CreateTemp(os.TempDir(), strings.ReplaceAll(t.Name(), "/", "")) |
Contributor
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
SA4006: this value of err is never used (staticcheck)
Owner
Author
|
Windows, I haven't seen your face for ten years and I almost forgot about you. |
Owner
Author
|
＼( 'ω')／ウオオオオオアアアーーーッ！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gup command may check standard output and standard errors in unit tests.
We know that error messages vary from platform to platform and that tests fail in some environments.
gup command returns an error message that is a concatenation of the "message executed for the gup command" and the "message returned by the golang standard package". Error messages returned by Golang's standard packages are platform-dependent.
To solve this problem I will add the github actions workflow(#44) to test on windows, mac and linux.