Use Chai for test cases#347
Closed
A-312 wants to merge 10 commits intomozilla:feat-multi-packages-splitfrom
A-312:strict-tests
Closed
Use Chai for test cases#347A-312 wants to merge 10 commits intomozilla:feat-multi-packages-splitfrom A-312:strict-tests
A-312 wants to merge 10 commits intomozilla:feat-multi-packages-splitfrom
A-312:strict-tests
Conversation
Contributor
Author
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
This PR is ready |
with current NPM registry state
Closed
This reverts commit b509acf.
Contributor
Author
|
this PR is ready :D |
madarche
force-pushed
the
feat-multi-packages-split
branch
from
7064166 to
051dd99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we can see "expected" and "actual" diff.
fix: #346 : Some test don't provide error message
fix: #345 : Replace should (=> Last publish 3 years ago) by Chai
Before (with must) :
After (with Chai) :
Choice I made :
I choose chai.expect instead chai.should because sometime should have a weird bug or doesn't work on undefined and make an error.