Fix #1933: Prevent closing real stdio when server exits#2391
Open
717986230 wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
Fix #1933: Prevent closing real stdio when server exits#2391717986230 wants to merge 2 commits intomodelcontextprotocol:mainfrom
717986230 wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
… exits When using transport="stdio", the server was closing sys.stdin.buffer and sys.stdout.buffer when exiting, causing subsequent stdio operations to fail with ValueError: I/O operation on closed file. This fix uses os.dup() to create duplicate file descriptors, so the original stdin/stdout remain open when the wrapper streams are closed. Fixes modelcontextprotocol#1933
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1933
Problem
When using
transport="stdio", the server closessys.stdin.bufferandsys.stdout.bufferwhen exiting, causing subsequent stdio operations to fail with:Root Cause
The
stdio_server()function wrapssys.stdin.bufferandsys.stdout.bufferdirectly. When these wrappers are closed (when the context manager exits), they also close the original system streams.Solution
Use
os.dup()to create duplicate file descriptors before wrapping:sys.stdin.fileno()andsys.stdout.fileno()This ensures the original stdin/stdout remain open when the wrapper streams are closed.
Testing
Tested with the reproduction case from the issue:
Pressing Ctrl+D to exit the server no longer causes "I/O operation on closed file" error.
This fix implements the proposed solution from the original issue.