fix(session): initialize $data property with default empty array#274
Open
woprrr wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(session): initialize $data property with default empty array#274woprrr wants to merge 1 commit intomodelcontextprotocol:mainfrom
woprrr wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
woprrr
commented
Apr 2, 2026
Prevents TypeError when $data is accessed before initialization on a newly created session. Replaces the isset($this->data) check in readData() with an explicit $loaded flag to preserve lazy loading from the session store. Fixes modelcontextprotocol#273
855dd2b to
9e2023d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Session::$datawith= []to preventTypeErrorwhen the property is accessed before initialization on a newly created sessionisset($this->data)check inreadData()with an explicit$loadedflag to preserve lazy loading from the session store$loaded = trueinclear()andhydrate()to maintain consistent stateFixes #273
Test plan
SessionTesttests passtestSaveBeforeReadInitializesDataconfirmssave()on a fresh session workstestSessionLoadsDataFromStoreOnConstructionconfirms lazy loading still works