Skip to content

Fix module mode linking on macOS #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChrisJefferson wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −7
Open

Fix module mode linking on macOS #697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions mlua-sys/build/main_inner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,22 @@ fn main() {
// Check if compilation and linking is handled by external crate
if cfg!(not(feature = "external")) {
let target_os = env::var("CARGO_CFG_TARGET_OS").unwrap();
if target_os == "windows" && cfg!(feature = "module") {
if !std::env::var("LUA_LIB_NAME").unwrap_or_default().is_empty() {
// Don't use raw-dylib linking
find::probe_lua();
return;
}
if cfg!(feature = "module") {
if target_os == "windows" {
if !std::env::var("LUA_LIB_NAME").unwrap_or_default().is_empty() {
// Don't use raw-dylib linking
find::probe_lua();
return;
}

println!("cargo:rustc-cfg=raw_dylib");
println!("cargo:rustc-cfg=raw_dylib");
} else if target_os == "macos" {
// macOS linker requires explicit opt-in to allow undefined
// symbols in dylibs. Lua C modules resolve these symbols at
// load time from the host interpreter.
println!("cargo:rustc-cdylib-link-arg=-undefined");
println!("cargo:rustc-cdylib-link-arg=dynamic_lookup");
}
}

#[cfg(not(feature = "module"))]
Expand Down
Loading