[WIP - feedback request] chore: max accepts from/to option#11
Closed
kjappelbaum wants to merge 0 commit intomljs:masterfrom
Closed
[WIP - feedback request] chore: max accepts from/to option#11kjappelbaum wants to merge 0 commit intomljs:masterfrom
kjappelbaum wants to merge 0 commit intomljs:masterfrom
Conversation
Member
|
I like the from-to notation, seems clear enough for me |
targos
reviewed
Sep 22, 2020
| */ | ||
| export default function max(input) { | ||
| export default function max(input, options = {}) { | ||
| let { from, to } = options; |
Member
There was a problem hiding this comment.
Suggested change
| let { from, to } = options; | |
| let { from = 0, to = input.length } = options; |
- Move this line after the validation of
inputto avoid errors if that is not an array - You can then remove the "if undefined" conditions below
targos
reviewed
Sep 22, 2020
| /** | ||
| * Computes the maximum of the given values | ||
| * @param {Array<number>} input | ||
| * @param {int} [options.from] - Start index (inclusive) for the slice within which we look for the max |
Member
There was a problem hiding this comment.
Suggested change
| * @param {int} [options.from] - Start index (inclusive) for the slice within which we look for the max | |
| * @param {number} [options.from] - Start index (inclusive) for the slice within which we look for the max |
int doesn't exist in JS/JSDoc
targos
reviewed
Sep 22, 2020
| for (let i = 1; i < input.length; i++) { | ||
| if (from === undefined) { | ||
| from = 0; | ||
| } else if ((from < 0) | (from > input.length)) { |
Member
There was a problem hiding this comment.
you can also check Number.isInteger(from). same for to
targos
reviewed
Sep 22, 2020
| if (input.length === 0) { | ||
| throw new TypeError('input must not be empty'); | ||
| } | ||
| let { fromIndex, toIndex } = options; |
Member
There was a problem hiding this comment.
Suggested change
| let { fromIndex, toIndex } = options; | |
| const { fromIndex = 0, toIndex = input.length } = options; |
Comment on lines
+20
to
+22
| if (fromIndex === undefined) { | ||
| fromIndex = 0; | ||
| } else if ( |
Member
There was a problem hiding this comment.
Suggested change
| if (fromIndex === undefined) { | |
| fromIndex = 0; | |
| } else if ( | |
| if ( |
| if (fromIndex === undefined) { | ||
| fromIndex = 0; | ||
| } else if ( | ||
| (fromIndex < 0) | |
Member
There was a problem hiding this comment.
Suggested change
| (fromIndex < 0) | | |
| (fromIndex < 0) || |
| fromIndex = 0; | ||
| } else if ( | ||
| (fromIndex < 0) | | ||
| (fromIndex > input.length) | |
Member
There was a problem hiding this comment.
Suggested change
| (fromIndex > input.length) | | |
| (fromIndex >= input.length) || |
fromIndex cannot be === input.length because that would leave no room for toIndex
| ) { | ||
| throw new Error( | ||
| 'start index must be greater than 0 and smaller equal than length', | ||
| 'start index must be a integer greater than 0 and smaller equal than length', |
Member
There was a problem hiding this comment.
Suggested change
| 'start index must be a integer greater than 0 and smaller equal than length', | |
| 'fromIndex must be a positive integer smaller than length', |
Comment on lines
+32
to
+34
| if (toIndex === undefined) { | ||
| toIndex = input.length; | ||
| } else if ( |
Member
There was a problem hiding this comment.
Suggested change
| if (toIndex === undefined) { | |
| toIndex = input.length; | |
| } else if ( | |
| if ( |
| if (toIndex === undefined) { | ||
| toIndex = input.length; | ||
| } else if ( | ||
| (toIndex <= fromIndex) | |
Member
There was a problem hiding this comment.
Suggested change
| (toIndex <= fromIndex) | | |
| (toIndex <= fromIndex) || |
| toIndex = input.length; | ||
| } else if ( | ||
| (toIndex <= fromIndex) | | ||
| (toIndex > input.length) | |
Member
There was a problem hiding this comment.
Suggested change
| (toIndex > input.length) | | |
| (toIndex > input.length) || |
| ) { | ||
| throw new Error( | ||
| 'to index must be greater equal than from index and smaller equal than length', | ||
| 'toIndex index must be a integer greater equal than fromIndex index and smaller equal than length', |
Member
There was a problem hiding this comment.
Suggested change
| 'toIndex index must be a integer greater equal than fromIndex index and smaller equal than length', | |
| 'toIndex must be an integer greater than fromIndex and at most equal to length', |
Contributor
Author
There was a problem hiding this comment.
wow! many thanks for your time and careful review!
kjappelbaum
pushed a commit
to kjappelbaum/array
that referenced
this pull request
Oct 5, 2020
- incorporating feedback from mljs#11
kjappelbaum
pushed a commit
to kjappelbaum/array
that referenced
this pull request
Oct 5, 2020
- incorporating feedback from mljs#11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is a PR to get feedback about the
from/tooptions to avoid slicing.In particular if
fromIndexas in some other methods?)tois exclusivemakes sense to you.
If it makes sense, I'll go forward and make the changes for all other methods were relevant such that we can use it for the baselines.