Skip to content

Fix multiline TextInput crash from TxDrawD2D reentrancy (#15990)#16003

Merged
iamAbhi-916 merged 1 commit intomainfrom
fix_multiline_crash
Apr 16, 2026
Merged

Fix multiline TextInput crash from TxDrawD2D reentrancy (#15990)#16003
iamAbhi-916 merged 1 commit intomainfrom
fix_multiline_crash

Conversation

@iamAbhi-916
Copy link
Copy Markdown
Contributor

@iamAbhi-916 iamAbhi-916 commented Apr 16, 2026 •
edited by microsoft-github-policy-service Bot
Loading

cherry pick : 778a82d

Microsoft Reviewers: Open in CodeFlow

@iamAbhi-916 @rnbot
[0.84] Fix multiline TextInput crash from TxDrawD2D reentrancy (#15990)
778a82d 
* Fix multiline TextInput crash from TxDrawD2D reentrancy

* Change files
@iamAbhi-916 iamAbhi-916 requested a review from a team as a code owner April 16, 2026 05:17
@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines Bot commented Apr 16, 2026

Azure Pipelines:
Successfully started running 1 pipeline(s).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

Performance Test Results

Branch: fix_multiline_crash
Commit: 2378999c
Time: 2026-04-16T05:44:24.265Z
Tests: 161/161 passed

✅ Passed

161 scenario(s) across 28 suite(s) — no regressions

SectionList

Scenario Mean Median StdDev Renders vs Baseline
SectionList mount 5.30ms 5.00ms ±1.16ms 1 +0.0%
SectionList unmount 0.40ms 0.00ms ±0.52ms 0 +0.0%
SectionList rerender 12.00ms 11.00ms ±2.45ms 2 +4.8%
SectionList with-3-sections-15-items 7.00ms 7.50ms ±1.41ms 1 +36.4%
SectionList with-5-sections-50-items 6.70ms 6.00ms ±1.16ms 1 +0.0%
SectionList with-10-sections-200-items 6.30ms 5.50ms ±1.83ms 1 +0.0%
SectionList with-20-sections-200-items 6.30ms 6.00ms ±2.06ms 1 +20.0%
SectionList with-section-separator 2.60ms 2.00ms ±1.58ms 1 +0.0%
SectionList with-item-separator 2.80ms 2.50ms ±1.40ms 1 +25.0%
SectionList with-header-footer 2.80ms 3.00ms ±0.63ms 1 +50.0%
SectionList with-section-footer 2.20ms 2.00ms ±0.63ms 1 +0.0%
SectionList with-sticky-section-headers 1.80ms 2.00ms ±0.92ms 1 +0.0%
SectionList with-empty-list 0.60ms 1.00ms ±0.52ms 1 +0.0%
SectionList with-50-sections-1000-items 3.00ms 3.00ms ±1.49ms 1 +50.0%

FlatList

Scenario Mean Median StdDev Renders vs Baseline
FlatList mount 4.30ms 4.00ms ±0.95ms 1 +0.0%
FlatList unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
FlatList rerender 11.10ms 11.00ms ±2.13ms 2 +22.2%
FlatList with-10-items 5.00ms 5.00ms ±0.47ms 1 +25.0%
FlatList with-100-items 5.10ms 5.00ms ±1.10ms 1 +0.0%
FlatList with-500-items 5.90ms 6.50ms ±1.52ms 1 +62.5%
FlatList with-1000-items 4.60ms 5.00ms ±0.84ms 1 +25.0%
FlatList horizontal 5.50ms 5.00ms ±2.01ms 1 +0.0%
FlatList with-separator 1.80ms 2.00ms ±0.79ms 1 +0.0%
FlatList with-header-footer 1.60ms 2.00ms ±0.52ms 1 +0.0%
FlatList with-empty-list 0.50ms 0.50ms ±0.53ms 1 +0.0%
FlatList with-get-item-layout 1.40ms 1.00ms ±0.52ms 1 +0.0%
FlatList inverted 1.40ms 1.00ms ±0.52ms 1 -33.3%
FlatList with-num-columns 3.30ms 3.00ms ±1.06ms 1 +0.0%

TouchableOpacity

Scenario Mean Median StdDev Renders vs Baseline
TouchableOpacity mount 1.00ms 1.00ms ±0.00ms 1 +0.0%
TouchableOpacity unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
TouchableOpacity rerender 1.10ms 1.00ms ±0.88ms 2 +0.0%
TouchableOpacity custom-active-opacity 1.00ms 1.00ms ±0.00ms 1 +0.0%
TouchableOpacity disabled 0.50ms 0.50ms ±0.53ms 1 -50.0%
TouchableOpacity with-all-handlers 0.40ms 0.00ms ±0.52ms 1 -100.0%
TouchableOpacity with-hit-slop 0.60ms 1.00ms ±0.52ms 1 +0.0%
TouchableOpacity with-delay 0.70ms 1.00ms ±0.48ms 1 +0.0%
TouchableOpacity nested 1.90ms 1.50ms ±1.52ms 1 +50.0%
TouchableOpacity multiple-10 7.33ms 7.00ms ±2.09ms 1 +16.7%
TouchableOpacity multiple-50 30.53ms 30.00ms ±5.51ms 1 +3.4%
TouchableOpacity multiple-100 56.00ms 53.00ms ±15.85ms 1 +6.0%

ScrollView

Scenario Mean Median StdDev Renders vs Baseline
ScrollView mount 0.50ms 0.50ms ±0.53ms 1 +Infinity%
ScrollView unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
ScrollView rerender 1.10ms 1.00ms ±0.32ms 2 +0.0%
ScrollView children-20 4.00ms 3.00ms ±1.93ms 1 -25.0%
ScrollView children-100 18.33ms 18.00ms ±3.81ms 1 +12.5%
ScrollView horizontal 4.60ms 4.50ms ±1.26ms 1 +12.5%
ScrollView sticky-headers 3.20ms 3.00ms ±1.69ms 1 +0.0%
ScrollView scroll-indicators 0.80ms 1.00ms ±0.42ms 1 +0.0%
ScrollView nested 1.60ms 1.00ms ±0.97ms 1 +0.0%
ScrollView content-container-style 1.30ms 1.00ms ±0.48ms 1 +0.0%
ScrollView children-500 24.87ms 24.00ms ±6.20ms 1 +26.3%

TouchableHighlight

Scenario Mean Median StdDev Renders vs Baseline
TouchableHighlight mount 0.50ms 0.50ms ±0.53ms 1 +0.0%
TouchableHighlight unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
TouchableHighlight rerender 0.70ms 1.00ms ±0.48ms 2 +0.0%
TouchableHighlight custom-underlay-color 0.60ms 1.00ms ±0.52ms 1 +Infinity%
TouchableHighlight custom-active-opacity 0.40ms 0.00ms ±0.52ms 1 +0.0%
TouchableHighlight disabled 0.30ms 0.00ms ±0.48ms 1 +0.0%
TouchableHighlight with-all-handlers 0.30ms 0.00ms ±0.48ms 1 +0.0%
TouchableHighlight with-hit-slop 0.40ms 0.00ms ±0.52ms 1 +0.0%
TouchableHighlight nested-touchables 0.90ms 1.00ms ±0.57ms 1 +0.0%
TouchableHighlight multiple-touchables-10 3.50ms 3.00ms ±1.65ms 1 +0.0%
TouchableHighlight multiple-touchables-50 15.70ms 15.50ms ±2.79ms 1 +24.0%
TouchableHighlight multiple-touchables-100 28.20ms 27.00ms ±2.62ms 1 +20.0%

Pressable

Scenario Mean Median StdDev Renders vs Baseline
Pressable mount 0.60ms 1.00ms ±0.52ms 1 +Infinity%
Pressable unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Pressable rerender 0.40ms 0.00ms ±0.52ms 2 -100.0%
Pressable with-all-handlers 0.40ms 0.00ms ±0.52ms 1 +0.0%
Pressable with-style-function 0.20ms 0.00ms ±0.42ms 1 +0.0%
Pressable disabled 0.30ms 0.00ms ±0.48ms 1 +0.0%
Pressable with-hit-slop 0.30ms 0.00ms ±0.48ms 1 +0.0%
Pressable nested 0.90ms 1.00ms ±0.32ms 1 +0.0%
Pressable multiple-10 4.07ms 4.00ms ±0.80ms 1 +33.3%
Pressable multiple-50 18.13ms 18.00ms ±3.02ms 1 +28.6%
Pressable multiple-100 19.20ms 14.00ms ±11.66ms 1 +16.7%

Modal

Scenario Mean Median StdDev Renders vs Baseline
Modal mount 0.50ms 0.50ms ±0.53ms 1 +Infinity%
Modal unmount 0.20ms 0.00ms ±0.42ms 0 +0.0%
Modal rerender 0.50ms 0.50ms ±0.53ms 2 +Infinity%
Modal slide-animation 0.40ms 0.00ms ±0.52ms 1 +0.0%
Modal fade-animation 0.40ms 0.00ms ±0.52ms 1 +0.0%
Modal transparent 0.50ms 0.50ms ±0.53ms 1 +Infinity%
Modal with-callbacks 0.30ms 0.00ms ±0.48ms 1 +0.0%
Modal rich-content 1.40ms 1.00ms ±0.52ms 1 -50.0%
Modal with-accessibility 0.40ms 0.00ms ±0.52ms 1 +0.0%

Image

Scenario Mean Median StdDev Renders vs Baseline
Image mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
Image unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Image rerender 0.10ms 0.00ms ±0.32ms 2 +0.0%
Image with-resize-mode 0.30ms 0.00ms ±0.48ms 1 +0.0%
Image with-border-radius 0.00ms 0.00ms ±0.00ms 1 +0.0%
Image with-tint-color 0.20ms 0.00ms ±0.42ms 1 +0.0%
Image with-blur-radius 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image with-accessibility 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image multiple-10 0.80ms 1.00ms ±0.41ms 1 +0.0%
Image multiple-50 4.27ms 4.00ms ±1.16ms 1 +33.3%
Image multiple-100 9.33ms 8.00ms ±2.44ms 1 +0.0%

ActivityIndicator

Scenario Mean Median StdDev Renders vs Baseline
ActivityIndicator mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
ActivityIndicator unmount 0.20ms 0.00ms ±0.42ms 0 +0.0%
ActivityIndicator rerender 0.30ms 0.00ms ±0.48ms 2 +0.0%
ActivityIndicator size-large 0.50ms 0.50ms ±0.53ms 1 +Infinity%
ActivityIndicator size-small 0.20ms 0.00ms ±0.42ms 1 +0.0%
ActivityIndicator with-color 0.40ms 0.00ms ±0.52ms 1 +0.0%
ActivityIndicator not-animating 0.20ms 0.00ms ±0.42ms 1 +0.0%
ActivityIndicator with-accessibility 0.30ms 0.00ms ±0.48ms 1 +0.0%
ActivityIndicator multiple-10 1.73ms 1.00ms ±1.53ms 1 +0.0%
ActivityIndicator multiple-50 5.73ms 5.00ms ±2.19ms 1 +25.0%
ActivityIndicator multiple-100 9.93ms 10.00ms ±2.34ms 1 +42.9%

Switch

Scenario Mean Median StdDev Renders vs Baseline
Switch mount 0.30ms 0.00ms ±0.48ms 1 +0.0%
Switch unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Switch rerender 0.30ms 0.00ms ±0.48ms 2 -100.0%
Switch value-true 0.30ms 0.00ms ±0.48ms 1 +0.0%
Switch disabled 0.30ms 0.00ms ±0.48ms 1 +0.0%
Switch custom-colors 0.30ms 0.00ms ±0.48ms 1 +0.0%
Switch on-value-change 0.30ms 0.00ms ±0.48ms 1 +0.0%
Switch with-accessibility 0.30ms 0.00ms ±0.48ms 1 +0.0%
Switch multiple-10 2.07ms 2.00ms ±1.16ms 1 +0.0%
Switch multiple-50 11.73ms 12.00ms ±3.06ms 1 +33.3%
Switch multiple-100 23.13ms 24.00ms ±6.51ms 1 +50.0%

Button

Scenario Mean Median StdDev Renders vs Baseline
Button mount 0.60ms 1.00ms ±0.52ms 1 +0.0%
Button unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Button rerender 1.20ms 1.00ms ±0.42ms 2 +0.0%
Button disabled 0.60ms 1.00ms ±0.52ms 1 +0.0%
Button with-color 0.60ms 1.00ms ±0.52ms 1 +100.0%
Button with-accessibility 0.60ms 1.00ms ±0.52ms 1 +0.0%
Button multiple-10 6.53ms 6.00ms ±2.23ms 1 +0.0%
Button multiple-50 23.93ms 27.00ms ±10.70ms 1 +0.0%
Button multiple-100 18.00ms 16.00ms ±4.57ms 1 -15.8%

TextInput

Scenario Mean Median StdDev Renders vs Baseline
TextInput mount 0.10ms 0.00ms ±0.32ms 1 +0.0%
TextInput unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
TextInput rerender 0.30ms 0.00ms ±0.48ms 2 +0.0%
TextInput multiline 0.20ms 0.00ms ±0.42ms 1 +0.0%
TextInput with-value 0.20ms 0.00ms ±0.42ms 1 +0.0%
TextInput styled 0.30ms 0.00ms ±0.48ms 1 +0.0%
TextInput multiple-100 8.07ms 8.00ms ±1.87ms 1 +14.3%

View

Scenario Mean Median StdDev Renders vs Baseline
View mount 0.10ms 0.00ms ±0.32ms 1 +0.0%
View unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
View rerender 0.20ms 0.00ms ±0.42ms 2 +0.0%
View nested-50 3.60ms 3.00ms ±1.24ms 1 +0.0%
View nested-100 9.47ms 9.00ms ±2.59ms 1 +28.6%
View shadow 0.20ms 0.00ms ±0.42ms 1 +0.0%
View border-radius 0.10ms 0.00ms ±0.32ms 1 +0.0%
View nested-500 18.93ms 13.00ms ±13.96ms 1 +30.0%

Text

Scenario Mean Median StdDev Renders vs Baseline
Text mount 0.30ms 0.00ms ±0.48ms 1 +0.0%
Text unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Text rerender 0.40ms 0.00ms ±0.52ms 2 +0.0%
Text long-1000 0.30ms 0.00ms ±0.48ms 1 +0.0%
Text nested 0.50ms 0.50ms ±0.53ms 1 +Infinity%
Text styled 0.20ms 0.00ms ±0.42ms 1 +0.0%
Text multiple-100 10.20ms 9.00ms ±2.62ms 1 +28.6%

SectionList.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
SectionList native mount 6.59ms 6.40ms ±1.16ms 1 -1.6%

FlatList.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
FlatList native mount 6.27ms 6.06ms ±1.03ms 1 -34.3%

TouchableHighlight.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
TouchableHighlight native mount 1.97ms 2.00ms ±0.23ms 1 -4.1%

TouchableOpacity.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
TouchableOpacity native mount 2.23ms 2.14ms ±0.28ms 1 -31.7%

Pressable.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Pressable native mount 1.86ms 1.86ms ±0.17ms 1 -26.0%

ScrollView.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
ScrollView native mount 4.07ms 3.79ms ±0.60ms 1 -6.4%

ActivityIndicator.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
ActivityIndicator native mount 1.62ms 1.59ms ±0.14ms 1 -35.8%

TextInput.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
TextInput native mount 2.50ms 2.47ms ±0.28ms 1 -39.5%

Switch.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Switch native mount 1.62ms 1.49ms ±0.46ms 1 -13.9%

Button.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Button native mount 2.39ms 2.14ms ±0.54ms 1 -17.6%

Modal.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Modal native mount 1.29ms 1.27ms ±0.13ms 1 +4.2%

Image.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Image native mount 2.08ms 2.00ms ±0.30ms 1 -11.5%

View.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
View native mount 1.50ms 1.38ms ±0.31ms 1 -3.2%

Text.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Text native mount 1.70ms 1.59ms ±0.28ms 1 -8.8%

@iamAbhi-916 iamAbhi-916 merged commit 7efd7f0 into main Apr 16, 2026
32 checks passed
@iamAbhi-916 iamAbhi-916 deleted the fix_multiline_crash branch April 16, 2026 09:06
@vineethkuttan vineethkuttan added this to the 0.84 milestone Apr 20, 2026
@acoates-ms acoates-ms mentioned this pull request Apr 25, 2026
Merged
acoates-ms added a commit that referenced this pull request Apr 25, 2026
@acoates-ms @iamAbhi-916 @gmacmaster
[0.81] Fix touch event handling, improve reliability, and optimize pe…
38021b8 
…rformance (#16050)

* Fix ScrollView keyboard scroll drift on long key press (#15988)

* Fix ScrollView keyboard scroll drift on long key press

* Change files

* [0.84] Fix multiline TextInput crash from TxDrawD2D reentrancy (#15990) (#16003)

* Fix multiline TextInput crash from TxDrawD2D reentrancy

* Change files

* Fix touch event handling, improve reliability, and optimize performance (#16048)

* Fix touch event handling, improve reliability, and optimize performance

- Fix touch/pen pointer device type detection and screenPoint coordinates
- Fix touch cancel to include all active touches per W3C spec
- Synthesize touch-cancel for stale pointers and releases outside views
- Fix TextInput pointer message translation (use mouse-style messages for RichEdit)
- Fix ShouldSubmit modifier key checks (altDown, ctrlKey)
- Add null safety to RootComponentView() for island teardown
- Fix Pressability hover timeout and tabIndex focusable mapping
- Cache event path to root to avoid repeated tree walks
- Use unordered_set for pointer capture tracking
- Eliminate O(n²) hit testing by caching visual children
- Skip snap scroll reconfiguration when unchanged
- Improve TextInput reliability: thread-safe loading, null safety, use-after-free fix
- Fix Timing data race and remove duplicate image error allocation
- Use unordered_set for animated node and component registry lookups
- Clean up dead code in ScrollView and simplify Modal event emitter init

* formatting

* Change files

* Update react-native-windows-cd995d7a-4df8-4c73-9b1b-c57b3b886cc6.json

* Touch target

* addressed pr comments

* Crash on invalid index

* revert until rn core pr

* Update react-native-windows-cd995d7a-4df8-4c73-9b1b-c57b3b886cc6.json

* format

* snapshots

---------

Co-authored-by: Gordon MacMaster <31481849+gmacmaster@users.noreply.github.com>
Co-authored-by: Gordon MacMaster <gordomacmaster@gmail.com>

* change files

* Fix some issues with rounded borders (#16051)

* Some fixes for rounded borders

* Change files

* Image snaphots

---------

Co-authored-by: Abhijeet Jha <74712637+iamAbhi-916@users.noreply.github.com>
Co-authored-by: Gordon MacMaster <31481849+gmacmaster@users.noreply.github.com>
Co-authored-by: Gordon MacMaster <gordomacmaster@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vineethkuttan vineethkuttan vineethkuttan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.84

Development

Successfully merging this pull request may close these issues.

2 participants

@iamAbhi-916 @vineethkuttan