chore: use langAliases from api.json in api generator#1907
Merged
yury-s merged 1 commit intomicrosoft:mainfrom Apr 9, 2026
Merged
chore: use langAliases from api.json in api generator#1907yury-s merged 1 commit intomicrosoft:mainfrom
yury-s merged 1 commit intomicrosoft:mainfrom
Conversation
The upstream playwright repo replaced the `[Object=Name]` struct naming syntax with explicit `alias-java`/`alias-csharp`/`alias` bullets on type definitions. Read those aliases in ApiGenerator and drop the hand-maintained `customTypeNames` map and the function-callback switch that previously hardcoded the same names. Falling back to the language-agnostic `alias` (matching the dotnet generator's `csharp || default` pattern) renames `Bind` to `BindResult` and `PausedDetails` to `DebuggerPausedDetails`; impl and test files are updated accordingly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dgozman
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
langAliases.java(with fallback to the language-agnosticdefault) fromapi.jsoninApiGeneratorto drive Java type names forObjectandfunctiontypes.customTypeNamesmap (28 entries:ClientCertificate,Cookie,HttpHeader,SelectOption,FilePayload,Position) and the hardcodedBindingCallback/FunctionCallbackswitch — these are all expressed as aliases in api.json now.alias:for them:Bind->BindResult,PausedDetails->DebuggerPausedDetails. Impl and test references are updated accordingly.This follows the upstream playwright change that introduced the alias bullets (microsoft/playwright#40122).