Skip to content

Add catalog signing for JS/XML content files#2543

Open
jesuszarate wants to merge 1 commit intomicrosoft:mainfrom
jesuszarate:dev/jezarat/catalog-sign-js-xml
Open

Add catalog signing for JS/XML content files#2543
jesuszarate wants to merge 1 commit intomicrosoft:mainfrom
jesuszarate:dev/jezarat/catalog-sign-js-xml

Conversation

@jesuszarate
Copy link
Copy Markdown
Member

Summary

Generate .cat (catalog) files covering all JS and XML content shipped in the NodejsTools and TestAdapter VSIXes. This fixes VS signing compliance for 32 unsigned files (31 .js + 1 .xml) flagged by the SignVerify scan.

Changes

  • Nodejs/Product/ProjectAfter.targets: Add \GenerateContentCatalog\ target that enumerates JS/XML source files, generates a CDF, runs \makecat.exe\, and signs the resulting .cat with Microsoft400. Add \IncludeCatalogInVsix\ target that includes the signed .cat in the VSIX container.
  • signWhiteList.txt: Remove .js and .xml exclusions so \MicroBuildCodesignVerify\ validates these files.

Payloads fixed

Payload Files
\msvsnodejstoolsnodejstools15803041\ 19 .js + 1 .xml
\msvsnodejstoolstestadapter15803041\ 12 .js

How it works

  1. \GenerateContentCatalog\ runs AfterTargets=Build for VSIX projects
  2. Collects all .js and .xml files from template/test framework directories
  3. Generates a CDF and runs makecat.exe to produce a .cat file
  4. MicroBuild signs the .cat with Microsoft400 via FilesToSign
  5. \IncludeCatalogInVsix\ adds the signed .cat to VSIXSourceItem before CreateVsixContainer

Bug

https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2982241

Generate .cat files covering all JS and XML content shipped in the
NodejsTools and TestAdapter VSIXes. This fixes VS signing compliance
for 32 unsigned files (31 .js + 1 .xml) flagged by the SignVerify scan.

- Add GenerateContentCatalog target in ProjectAfter.targets
- Add IncludeCatalogInVsix target to ship .cat in VSIX
- Update signWhiteList.txt to remove .js and .xml exclusions

Bug: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2982241
@jesuszarate jesuszarate marked this pull request as ready for review April 27, 2026 18:38
@jesuszarate
Copy link
Copy Markdown
Member Author

@joj could you take a look at my PR? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant