Add catalog signing for JS/XML content files#2543
Open
jesuszarate wants to merge 1 commit intomicrosoft:mainfrom
Open
Add catalog signing for JS/XML content files#2543jesuszarate wants to merge 1 commit intomicrosoft:mainfrom
jesuszarate wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Generate .cat files covering all JS and XML content shipped in the NodejsTools and TestAdapter VSIXes. This fixes VS signing compliance for 32 unsigned files (31 .js + 1 .xml) flagged by the SignVerify scan. - Add GenerateContentCatalog target in ProjectAfter.targets - Add IncludeCatalogInVsix target to ship .cat in VSIX - Update signWhiteList.txt to remove .js and .xml exclusions Bug: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2982241
Member
Author
|
@joj could you take a look at my PR? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generate .cat (catalog) files covering all JS and XML content shipped in the NodejsTools and TestAdapter VSIXes. This fixes VS signing compliance for 32 unsigned files (31 .js + 1 .xml) flagged by the SignVerify scan.
Changes
Payloads fixed
How it works
Bug
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2982241