Skip to content

ApplicationData: Unpackaged support#6277

Merged
DrusTheAxe merged 32 commits into
mainfrom
user/drustheaxe/appdata-unpackaged
Apr 1, 2026
Merged

ApplicationData: Unpackaged support#6277
DrusTheAxe merged 32 commits into
mainfrom
user/drustheaxe/appdata-unpackaged

Conversation

@DrusTheAxe
Copy link
Copy Markdown
Member

@DrusTheAxe DrusTheAxe commented Mar 9, 2026

Provide ApplicationData Unpackaged support

#close #2639

@DrusTheAxe DrusTheAxe added this to the 2.0 milestone Mar 9, 2026
@DrusTheAxe DrusTheAxe self-assigned this Mar 9, 2026
@DrusTheAxe DrusTheAxe added the area-ApplicationData Topics related to ApplicationData APIs in the Microsoft.Windows.Storage namespace label Mar 9, 2026
@DrusTheAxe
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@DrusTheAxe
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@DrusTheAxe
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@DrusTheAxe DrusTheAxe requested a review from letao-msft March 27, 2026 04:14
Comment thread dev/ApplicationData/UnpackagedApplicationData.cpp Outdated
Comment thread dev/ApplicationData/UnpackagedApplicationDataContainer.cpp
letao-msft
letao-msft previously approved these changes Mar 27, 2026
Copy link
Copy Markdown
Contributor

@letao-msft letao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DrusTheAxe
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe
Copy link
Copy Markdown
Member Author

/azp run

@DrusTheAxe DrusTheAxe requested a review from letao-msft March 31, 2026 07:37
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@letao-msft letao-msft dismissed their stale review March 31, 2026 16:03

revoking review

letao-msft
letao-msft previously approved these changes Mar 31, 2026
Copy link
Copy Markdown
Contributor

@letao-msft letao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DrusTheAxe
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@letao-msft letao-msft dismissed their stale review April 1, 2026 01:03

Re-approving

Copy link
Copy Markdown
Contributor

@letao-msft letao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DrusTheAxe
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe DrusTheAxe enabled auto-merge (squash) April 1, 2026 05:14
@DrusTheAxe DrusTheAxe merged commit 7c324df into main Apr 1, 2026
49 checks passed
@DrusTheAxe DrusTheAxe deleted the user/drustheaxe/appdata-unpackaged branch April 1, 2026 21:36
DrusTheAxe added a commit that referenced this pull request Apr 2, 2026
* ApplicationData.GetForUnpackaged() and supporting implementation

* Integrated UnpackagedApplicationData into ApplicationData

* Added tests. Removed debugging and dead code
Scottj1s added a commit that referenced this pull request May 28, 2026
…ata.GetForUnpackaged() (#6371)

* ApplicationData: Unpackaged support (#6277)

* ApplicationData.GetForUnpackaged() and supporting implementation

* Integrated UnpackagedApplicationData into ApplicationData

* Added tests. Removed debugging and dead code

* 61684930: [2.0 servicing] WindowsAppSDK: Microsoft.Windows.Storage.ApplicationData.GetForUnpackaged()

* Fixed RuntimeCompatibility symbol reference

* ApplicationData: Refactor to dual-type pattern for packaged/unpackaged (#6378)

* ApplicationData: Refactor to dual-type pattern for packaged/unpackaged

Replace runtime branching (if m_unpackagedApplicationData) with separate
WinRT implementation types. Both ApplicationData and UnpackagedApplicationData
now derive directly from ApplicationDataT, and the factory constructs the
appropriate type. Same pattern applied to ApplicationDataContainer.

This eliminates 17+ repeated if-checks, removes the shared_ptr indirection
for containers, and makes each type self-contained with no branching.

* Add [[maybe_unused]] to parameters in UnpackagedApplicationData

Updated function signatures to use [[maybe_unused]] for unused parameters.

---------

Co-authored-by: agniuks <41223743+agniuks@users.noreply.github.com>

* Update change ID for GetForUnpackaged method

---------

Co-authored-by: agniuks <41223743+agniuks@users.noreply.github.com>
Co-authored-by: Scott Jones <sjones@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-ApplicationData Topics related to ApplicationData APIs in the Microsoft.Windows.Storage namespace

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsoft.Storage.ApplicationData

2 participants