Add Intl.PluralRules.selectRange typing to es2023.intl#63424
Open
3ru wants to merge 1 commit intomicrosoft:mainfrom
Open
Add Intl.PluralRules.selectRange typing to es2023.intl#634243ru wants to merge 1 commit intomicrosoft:mainfrom
Intl.PluralRules.selectRange typing to es2023.intl#634243ru wants to merge 1 commit intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
1 similar comment
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the missing Intl.PluralRules.prototype.selectRange declaration to the ES2023 Intl lib definition, along with a conformance test and baselines to validate the new typing.
Changes:
- Extend
Intl.PluralRulesines2023.intlwithselectRange(start, end): Intl.LDMLPluralRule. - Add a conformance test that exercises
selectRangeunder--lib es2022,es2023.intl. - Add reference baselines (.types/.symbols/.js) for the new conformance test.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/lib/es2023.intl.d.ts |
Adds Intl.PluralRules#selectRange typing for ES2023 Intl. |
tests/cases/conformance/es2023/intlPluralRulesSelectRangeES2023.ts |
New conformance test covering selectRange typing and return type. |
tests/baselines/reference/intlPluralRulesSelectRangeES2023.types |
Baseline asserting inferred types for the new test. |
tests/baselines/reference/intlPluralRulesSelectRangeES2023.symbols |
Baseline asserting symbol binding for the new test. |
tests/baselines/reference/intlPluralRulesSelectRangeES2023.js |
Baseline asserting emit output for the new test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #58084
This adds the missing
Intl.PluralRules.prototype.selectRangetyping tosrc/lib/es2023.intl.d.ts