Backport tsgo PR 3301 for testing by jakebailey · Pull Request #63328 · microsoft/TypeScript

jakebailey · 2026-03-31T17:44:24Z

Want to check perf on microsoft/typescript-go#3301

jakebailey · 2026-03-31T17:44:45Z

typescript-bot · 2026-03-31T17:44:49Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2026-03-31T18:11:17Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2026-03-31T18:14:23Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/63328/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Git clone failed"

Otherwise...

Everything looks good!

typescript-bot · 2026-03-31T18:42:08Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_82,521	_82,521	_~	_~	_~	_{p=1.000 n=6}
_Types	_125,280	_125,280	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{275,071k (± 0.49%)}	_{276,200k (± 0.69%)}	_~	_274,404k	_277,994k	_{p=0.378 n=6}
_{Parse Time}	_{1.30s (± 0.79%)}	_{1.31s (± 0.31%)}	_~	_1.30s	_1.31s	_{p=0.461 n=6}
_{Bind Time}	_{0.75s (± 1.00%)}	_0.75s	_~	_~	_~	_{p=0.598 n=6}
_{Check Time}	_{14.16s (± 0.47%)}	_{14.12s (± 0.25%)}	_~	_14.06s	_14.16s	_{p=0.377 n=6}
_{Emit Time}	_{2.66s (± 0.60%)}	_{2.66s (± 0.41%)}	_~	_2.65s	_2.68s	_{p=1.000 n=6}
_{Total Time}	_{18.87s (± 0.32%)}	_{18.84s (± 0.18%)}	_~	_18.78s	_18.87s	_{p=0.293 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_959,140	_959,140	_~	_~	_~	_{p=1.000 n=6}
_Types	_416,033	_416,033	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,261,175k (± 0.00%)}	_{1,261,108k (± 0.00%)}	_{-67k (- 0.01%)}	_1,261,044k	_1,261,180k	_{p=0.045 n=6}
_{Parse Time}	_{6.53s (± 0.77%)}	_{6.52s (± 0.59%)}	_~	_6.50s	_6.60s	_{p=0.936 n=6}
_{Bind Time}	_{1.97s (± 0.56%)}	_{1.97s (± 0.21%)}	_~	_1.96s	_1.97s	_{p=0.445 n=6}
_{Check Time}	_{32.45s (± 0.51%)}	_{32.36s (± 0.52%)}	_~	_32.14s	_32.55s	_{p=0.423 n=6}
_{Emit Time}	_{15.08s (± 0.82%)}	_{15.09s (± 0.41%)}	_~	_15.01s	_15.17s	_{p=0.687 n=6}
_{Total Time}	_{56.02s (± 0.47%)}	_{55.94s (± 0.39%)}	_~	_55.68s	_56.29s	_{p=0.689 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	_11,136	_11,136	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,425,801	_2,425,801	_~	_~	_~	_{p=1.000 n=6}
_Types	_768,504	_768,504	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,753,432k (± 0.00%)}	_{2,753,429k (± 0.00%)}	_~	_2,753,335k	_2,753,494k	_{p=0.810 n=6}
_{Parse Time}	_{7.87s (± 0.13%)}	_{7.86s (± 0.20%)}	_~	_7.84s	_7.88s	_{p=0.458 n=6}
_{Bind Time}	_{2.05s (± 0.50%)}	_{2.04s (± 0.74%)}	_~	_2.02s	_2.06s	_{p=0.346 n=6}
_{Check Time}	_{73.27s (± 0.32%)}	_{73.99s (± 1.48%)}	_~	_72.72s	_75.14s	_{p=0.521 n=6}
_{Emit Time}	_{0.30s (± 1.70%)}	_{0.30s (± 2.52%)}	_~	_0.29s	_0.31s	_{p=0.241 n=6}
_{Total Time}	_{83.49s (± 0.28%)}	_{84.19s (± 1.29%)}	_~	_82.92s	_85.32s	_{p=0.574 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,363	_1,227,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,198	_267,198	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,352,459k (± 0.02%)}	_{2,473,654k (± 7.60%)}	_~	_2,351,381k	_2,717,012k	_{p=0.689 n=6}
_{Parse Time}	_{5.22s (± 0.72%)}	_{5.22s (± 1.10%)}	_~	_5.13s	_5.30s	_{p=1.000 n=6}
_{Bind Time}	_{1.87s (± 1.92%)}	_{1.84s (± 1.01%)}	_~	_1.82s	_1.87s	_{p=0.223 n=6}
_{Check Time}	_{35.82s (± 0.24%)}	_{35.79s (± 0.83%)}	_~	_35.23s	_36.13s	_{p=0.575 n=6}
_{Emit Time}	_{3.08s (± 3.77%)}	_{3.11s (± 3.85%)}	_~	_2.99s	_3.27s	_{p=0.575 n=6}
_{Total Time}	_{46.01s (± 0.47%)}	_{45.97s (± 0.73%)}	_~	_45.33s	_46.26s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,363	_1,227,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,198	_267,198	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,812,056k (± 8.47%)}	_{2,811,949k (± 8.45%)}	_~	_2,423,268k	_3,147,953k	_{p=1.000 n=6}
_{Parse Time}	_{6.78s (± 0.69%)}	_{6.77s (± 0.88%)}	_~	_6.73s	_6.89s	_{p=0.810 n=6}
_{Bind Time}	_{2.27s (± 1.59%)}	_{2.27s (± 1.20%)}	_~	_2.24s	_2.31s	_{p=0.747 n=6}
_{Check Time}	_{42.90s (± 1.26%)}	_{42.96s (± 1.24%)}	_~	_42.39s	_43.79s	_{p=0.936 n=6}
_{Emit Time}	_{3.47s (± 1.72%)}	_{3.57s (± 2.51%)}	_~	_3.45s	_3.69s	_{p=0.066 n=6}
_{Total Time}	_{55.43s (± 1.09%)}	_{55.57s (± 1.08%)}	_~	_54.91s	_56.49s	_{p=0.689 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,660	_261,660	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,323	_104,323	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{439,388k (± 0.01%)}	_{439,362k (± 0.01%)}	_~	_439,325k	_439,381k	_{p=0.377 n=6}
_{Parse Time}	_{3.50s (± 0.82%)}	_{3.54s (± 0.77%)}	_~	_3.50s	_3.58s	_{p=0.091 n=6}
_{Bind Time}	_{1.37s (± 1.78%)}	_{1.37s (± 1.03%)}	_~	_1.35s	_1.39s	_{p=1.000 n=6}
_{Check Time}	_{19.28s (± 0.42%)}	_{19.33s (± 0.48%)}	_~	_19.23s	_19.49s	_{p=0.419 n=6}
_{Emit Time}	_{1.54s (± 0.67%)}	_{1.55s (± 1.26%)}	_~	_1.52s	_1.58s	_{p=0.220 n=6}
_{Total Time}	_{25.69s (± 0.38%)}	_{25.79s (± 0.35%)}	_~	_25.69s	_25.93s	_{p=0.107 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₂₇₁	₂₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,897	_225,897	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,564	_93,564	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,631k (± 0.01%)}	_{371,663k (± 0.02%)}	_~	_371,582k	_371,780k	_{p=0.688 n=6}
_{Parse Time}	_{2.86s (± 0.75%)}	_{2.87s (± 0.85%)}	_~	_2.84s	_2.89s	_{p=0.935 n=6}
_{Bind Time}	_{1.63s (± 1.52%)}	_{1.64s (± 1.02%)}	_~	_1.62s	_1.67s	_{p=0.464 n=6}
_{Check Time}	_{17.48s (± 0.56%)}	_{17.49s (± 0.36%)}	_~	_17.40s	_17.55s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.97s (± 0.46%)}	_{22.00s (± 0.33%)}	_~	_21.89s	_22.08s	_{p=0.689 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=NaN n=0}
_Symbols	₀	₀	_~	_~	_~	_{p=NaN n=0}
_Types	₀	₀	_~	_~	_~	_{p=NaN n=0}
_{Memory used}	_0k	_0k	_~	_~	_~	_{p=NaN n=0}
_{Parse Time}	_0s	_0s	_~	_~	_~	_{p=NaN n=0}
_{Bind Time}	_0s	_0s	_~	_~	_~	_{p=NaN n=0}
_{Check Time}	_0s	_0s	_~	_~	_~	_{p=NaN n=0}
_{Emit Time}	_0s	_0s	_~	_~	_~	_{p=NaN n=0}
_{Total Time}	_0s	_0s	_~	_~	_~	_{p=NaN n=0}
_{webpack - node (v18.15.0, x64)}
_Errors	₈	₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_408,840	_408,840	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,909	_186,909	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{571,744k (± 0.02%)}	_{571,818k (± 0.02%)}	_~	_571,714k	_571,970k	_{p=0.471 n=6}
_{Parse Time}	_{4.71s (± 0.40%)}	_{4.73s (± 1.04%)}	_~	_4.67s	_4.79s	_{p=0.419 n=6}
_{Bind Time}	_{2.05s (± 0.91%)}	_{2.05s (± 1.18%)}	_~	_2.03s	_2.10s	_{p=0.744 n=6}
_{Check Time}	_{24.43s (± 0.36%)}	_{24.54s (± 0.46%)}	_~	_24.42s	_24.70s	_{p=0.125 n=6}
_{Emit Time}	_{0.01s (±77.38%)}	_{0.00s (±154.76%)}	_~	_0.00s	_0.01s	_{p=0.311 n=6}
_{Total Time}	_{31.19s (± 0.28%)}	_{31.33s (± 0.39%)}	_~	_31.19s	_31.50s	_{p=0.127 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_782,787	_782,787	_~	_~	_~	_{p=1.000 n=6}
_Types	_228,290	_228,290	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{698,151k (± 0.00%)}	_{698,189k (± 0.01%)}	_~	_698,097k	_698,370k	_{p=0.936 n=6}
_{Parse Time}	_{4.94s (± 0.58%)}	_{4.95s (± 0.58%)}	_~	_4.91s	_4.99s	_{p=0.293 n=6}
_{Bind Time}	_{1.60s (± 0.83%)}	_{1.59s (± 0.76%)}	_~	_1.58s	_1.61s	_{p=0.315 n=6}
_{Check Time}	_{23.04s (± 0.35%)}	_{23.20s (± 1.55%)}	_~	_22.99s	_23.93s	_{p=0.296 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{29.58s (± 0.31%)}	_{29.74s (± 1.27%)}	_~	_29.54s	_30.51s	_{p=0.334 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2026-03-31T19:04:43Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/63328/merge:

Something interesting changed - please have a look.

Details

SBoudrias/Inquirer.js

1 of 23 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2722: Cannot invoke an object which is possibly 'undefined'.
- packages/rawlist/src/index.ts#L215
error TS2349: This expression is not callable.
- packages/rawlist/src/index.ts#L215

packages/testing/tsconfig.json

error TS2722: Cannot invoke an object which is possibly 'undefined'.
- packages/rawlist/src/index.ts#L215
error TS2349: This expression is not callable.
- packages/rawlist/src/index.ts#L215

packages/rawlist/tsconfig.json

error TS2722: Cannot invoke an object which is possibly 'undefined'.
- packages/rawlist/src/index.ts#L215
error TS2349: This expression is not callable.
- packages/rawlist/src/index.ts#L215

packages/prompts/tsconfig.json

error TS2722: Cannot invoke an object which is possibly 'undefined'.
- packages/rawlist/src/index.ts#L215
error TS2349: This expression is not callable.
- packages/rawlist/src/index.ts#L215

packages/inquirer/tsconfig.json

error TS2722: Cannot invoke an object which is possibly 'undefined'.
- packages/rawlist/src/index.ts#L215
error TS2349: This expression is not callable.
- packages/rawlist/src/index.ts#L215

packages/i18n/tsconfig.json

error TS2722: Cannot invoke an object which is possibly 'undefined'.
- packages/rawlist/src/index.ts#L215
error TS2349: This expression is not callable.
- packages/rawlist/src/index.ts#L215

packages/demo/tsconfig.json

error TS2722: Cannot invoke an object which is possibly 'undefined'.
- packages/rawlist/src/index.ts#L215
error TS2349: This expression is not callable.
- packages/rawlist/src/index.ts#L215

RyanCavanaugh · 2026-03-31T20:44:27Z

Reduced version from that repo

 type MakePartial<T> = T extends object ? { [P in keyof T]?: T[P] } : T;
 
 declare function merge<T extends object>(x: MakePartial<T>, y: MakePartial<T>): T;
 
 declare const a: { fn: () => void };
 declare const b: MakePartial<{ fn: () => void; extra: number }>;
 
 const m = merge(a, b);
 m.fn(); // TS2722: Cannot invoke an object which is possibly 'undefined'.

Backport tsog PR 3301 for testing

96faf0a

jakebailey changed the title ~~Backport tsog PR 3301 for testing~~ Backport tsgo PR 3301 for testing Mar 31, 2026

This was referenced Mar 31, 2026

Fix type inference ordering inconsistency with discriminated unions and flatMap microsoft/typescript-go#3301

Draft

Inconsistency involving discriminated union and flatMap microsoft/typescript-go#1057

Open

RyanCavanaugh closed this Apr 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport tsgo PR 3301 for testing#63328

Backport tsgo PR 3301 for testing#63328
jakebailey wants to merge 1 commit intomicrosoft:mainfrom
jakebailey:port-tsgo3301

jakebailey commented Mar 31, 2026

Uh oh!

jakebailey commented Mar 31, 2026

Uh oh!

typescript-bot commented Mar 31, 2026 •

edited

Loading

Uh oh!

typescript-bot commented Mar 31, 2026

Uh oh!

typescript-bot commented Mar 31, 2026

Uh oh!

typescript-bot commented Mar 31, 2026

tsc

Uh oh!

typescript-bot commented Mar 31, 2026

SBoudrias/Inquirer.js

tsconfig.json

packages/testing/tsconfig.json

packages/rawlist/tsconfig.json

packages/prompts/tsconfig.json

packages/inquirer/tsconfig.json

packages/i18n/tsconfig.json

packages/demo/tsconfig.json

Uh oh!

RyanCavanaugh commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jakebailey commented Mar 31, 2026

Uh oh!

jakebailey commented Mar 31, 2026

Uh oh!

typescript-bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 31, 2026

Uh oh!

typescript-bot commented Mar 31, 2026

Uh oh!

typescript-bot commented Mar 31, 2026

tsc

Uh oh!

typescript-bot commented Mar 31, 2026

Uh oh!

RyanCavanaugh commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typescript-bot commented Mar 31, 2026 •

edited

Loading