chore: disallows unicode escape sequence in JSX#48609
Merged
RyanCavanaugh merged 9 commits intoAug 9, 2023
Merged
Conversation
RyanCavanaugh
requested changes
Apr 8, 2022
Member
RyanCavanaugh
left a comment
RyanCavanaugh
left a comment
There was a problem hiding this comment.
We should do this check in the checker instead. It's not scalable to add a parameter to parseRightSideOfDot (which is used everywhere) for this.
Contributor
Author
It require information from |
jakebailey
reviewed
Apr 21, 2022
Member
I checked, and that function only has a couple of call sites (but I have no doubt that it's called a lot); I think adding another required param is not too expensive here. |
Member
|
I think you had a bad merge; there's a load of commits on this PR now that shouldn't be. |
Jack-Works
force-pushed
the
disallow-unicode-escape-sequence-jsx
branch
from
134e4ba to
1c40ed5
Compare
Jack-Works
force-pushed
the
disallow-unicode-escape-sequence-jsx
branch
from
1c40ed5 to
63cf201
Compare
Contributor
Author
|
merge conflict fixed. |
jakebailey
approved these changes
Jul 19, 2022
Contributor
Author
|
rebased |
Contributor
Author
|
ping @RyanCavanaugh |
Jack-Works
force-pushed
the
disallow-unicode-escape-sequence-jsx
branch
2 times, most recently
from
eba9910 to
9851e90
Compare
Contributor
Author
|
hello, @RyanCavanaugh can we have this merged? it has been nearly 1 year. This is the blocker of JSX specification cleanup. |
jakebailey
reviewed
Jan 23, 2023
Member
|
I'm not sure Ryan has had a chance to look at this, but coming back to this (a lot later), this is how I would have implemented this myself, so I think it's okay. |
Member
|
@typescript-bot test this |
Collaborator
|
Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at 4e1734a. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 4e1734a. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @jakebailey, I've started to run the perf test suite on this PR at 4e1734a. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at 4e1734a. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @jakebailey, I've started to run the extended test suite on this PR at 4e1734a. You can monitor the build here. |
Collaborator
|
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 4e1734a. You can monitor the build here. |
Collaborator
|
Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 4e1734a. You can monitor the build here. Update: The results are in! |
Collaborator
|
@jakebailey Here are the results of running the user test suite comparing Everything looks good! |
1 similar comment
Collaborator
|
@jakebailey Here are the results of running the user test suite comparing Everything looks good! |
Collaborator
|
Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
Collaborator
|
@jakebailey Here they are:
CompilerComparison Report - main..48609
System
Hosts
Scenarios
TSServerComparison Report - main..48609
System
Hosts
Scenarios
StartupComparison Report - main..48609
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Collaborator
|
@jakebailey Here are the results of running the top-repos suite comparing Everything looks good! |
Collaborator
|
@jakebailey Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Detailspalantir/blueprint
|
Member
|
I've merged main back into this to fix the conflict. My impression from a recent discussion is that we are looking to move parse-checks out of the checker and into the parser, and I think this is an example of that. |
Jack-Works
changed the title
enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Contributor
Author
|
cc @RyanCavanaugh can we merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #48596