VSCode mixes import and require syntaxes on auto-import

[naoey]

In this particular instance I encountered the bug with moment.js.

• VSCode Version: 1.30.0-insider, 1.29.1
• OS Version: Windows 10 (1803), macOS 10.14.1

Steps to Reproduce:

1. Begin typing usage of an un-imported module
2. Press enter on auto-import intellisense suggestion

Does this issue occur when all extensions are disabled?: Yes

Above recording is on fresh Insiders install with extensions disabled and being reproduced in a fresh project with just React and moment installed through yarn.

[mjbvz]

Tested with 3.3.0-dev.2018121. In a blank js file that is not part of any jsconfig project, moment is added as:

import moment = require('moment');

moment()

[weswigham]

If esModuleInterop is on, we should probably prefer default imports over import =.

[DanielRosenwasser]

Is that the ideal behavior, or current behavior?

[weswigham]

Ideal, I believe

[jpike88]

I have this issue too, but I don't have esModuleInterop on as it's not needed, I'm using es7 lib and esnext as target and module

[filipef101]

Any solution?