Skip to content

Remove BroadcastChannelEventMap#668

Closed
goodmind wants to merge 1 commit into
microsoft:masterfrom
goodmind:patch-1
Closed

Remove BroadcastChannelEventMap#668
goodmind wants to merge 1 commit into
microsoft:masterfrom
goodmind:patch-1

Conversation

@goodmind
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Contributor

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to rebuild lib.dom.ts.

Also, this is used in the BroadcastChannel.addEventListener(…) method to provide type information.

@goodmind
Copy link
Copy Markdown
Author

goodmind commented Apr 3, 2019

There is already one generated from IDL

@saschanaz
Copy link
Copy Markdown
Collaborator

Covered and fixed by #647.

@goodmind goodmind closed this Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants