Moved hard coded Wifi credentials into new platformio.credentials.ini#1685
Closed
DerWossi wants to merge 6 commits into
Closed
Moved hard coded Wifi credentials into new platformio.credentials.ini#1685DerWossi wants to merge 6 commits into
DerWossi wants to merge 6 commits into
Conversation
|
See #1648 |
Author
|
@alexsporn Implementing WifiManager would be the “perfect” solution, but it would increase complexity and requires resources. |
Member
|
Hi, thanks for the contribution. Looks like you commit your WiFi credentials in the PR. Also please ensure PRs are opened against dev branch. Will close for now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardcoding login credentials poses a security risk.
Therefore, I have moved them to a new file that can be kept private.