Skip to content

Hybrid mode is always comparing to baseline images #132

@ConorMacBride

Description

@ConorMacBride

When using the hybrid mode it is documented that "the baseline images [are] only used if the hash
comparison fails" and "if the hashes match, the baseline images won't be retrieved". Changes introduced in #108 mean that if a baseline directory is specified, they are always downloaded and compared against (but they do not influence the test result). The --results-always behaves as documented, but the hybrid mode doesn't.

Steps to fix:

  1. Only download and compare baseline image if --results-always not set and hash comparison failed.
  2. If generating a HTML summary, don't prune the result image that the hash comparison test creates. (To keep the effect that Force results-always when generating HTML #131 would add.)

Should be a small enough fix. Probably best to not do a release until I fix this? Should have some time tomorrow evening.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions