Skip to content

you cannot run "npm install" inside of preinstall. this creates an install loop in npm 3+ #650

@tjwebb

Description

@tjwebb

because of this: df7d542

You cannot run npm install anything inside of the preinstall, because npm install runs preinstall.
This is pointless, anyway, because node-pre-gyp is a dependency already.

This happens:

$ npm install mapnik
(node:34121) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
fetchMetadata → network   ▌ ╢███████████████████████████████████░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░╟

> mapnik@3.5.13 preinstall /Users/tjwebb/workspace/langa/underbuilt/api-server/node_modules/.staging/mapnik-d6304832
> npm install node-pre-gyp

(node:34209) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.

> mapnik@3.5.13 preinstall /Users/tjwebb/workspace/langa/underbuilt/api-server/node_modules/.staging/mapnik-d6304832/node_modules/.staging/mapnik-5b75902b
> npm install node-pre-gyp

(node:34265) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.

> mapnik@3.5.13 preinstall /Users/tjwebb/workspace/langa/underbuilt/api-server/node_modules/.staging/mapnik-d6304832/node_modules/.staging/mapnik-5b75902b/node_modules/.staging/mapnik-3e3892ff
> npm install node-pre-gyp

and so on, forever, until eventually it looks like this:

/Users/tjwebb/workspace/langa/underbuilt/api-server/node_modules/.staging/mapnik-d6304832/node_modules/.staging/mapnik-5b75902b/node_modules/.staging/mapnik-3e3892ff/node_modules/.staging/mapnik-6a353413/node_modules/.staging/mapnik-872c850e/node_modules/.staging/mapnik-8edd7495/node_modules/.staging/mapnik-ada28736/node_modules/.staging/mapnik-aa3f2198/node_modules/.staging/mapnik-129f704a/node_modules/.staging/mapnik-9e1cde87/node_modules/.staging/mapnik-89279f14/node_modules/.staging/mapnik-7b7084a4/npm-debug.log

etc.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions