add one missing data resource back to icu63.1-min-static-data-1#673
Merged
Conversation
kevinkreiser
commented
Nov 20, 2018
| # Build ICU common package (libicuuc.a) with data file separate and with support for legacy conversion and break iteration turned off in order to minimize size | ||
|
|
||
| MASON_NAME=icu | ||
| MASON_VERSION=63.1-min-static-data-1 |
Contributor
Author
There was a problem hiding this comment.
first difference from the 63.1-min-static-data package is the name change here, adding a -1 to the end to denote the change.
kevinkreiser
commented
Nov 20, 2018
| sed -i'' -e '/^#/!s/SOURCE.*=.*txt/SOURCE = da.txt de.txt en.txt eo.txt es.txt fi.txt fr.txt he.txt id.txt it.txt ko.txt my.txt nl.txt pl.txt pt.txt pt_PT.txt ro.txt ru.txt sv.txt tr.txt uk.txt vi.txt zh.txt zh_Hans.txt/g' $l | ||
| # if its misc we need a couple of things | ||
| elif [ $(echo $l | grep -cF "misc") -eq 1 ]; then | ||
| sed -i'' -e '/^#/!s/SOURCE.*=.*txt/SOURCE = plurals.txt numberingSystems.txt icuver.txt icustd.txt pluralRanges.txt/g' $l |
Contributor
Author
There was a problem hiding this comment.
this is the only other difference in this package. we've added plurals.txt to the list of data to keep in the library. it turns out this is required to get the library to spit out 1 mile instead of 1 miles. 🤦♂️
Contributor
There was a problem hiding this comment.
wow, nice work figuring this out 🙌
springmeyer
approved these changes
Nov 20, 2018
Contributor
springmeyer
left a comment
springmeyer
left a comment
There was a problem hiding this comment.
👍 looks good, please trigger and merge once the trigger is 🍏
| # Build ICU common package (libicuuc.a) with data file separate and with support for legacy conversion and break iteration turned off in order to minimize size | ||
|
|
||
| MASON_NAME=icu | ||
| MASON_VERSION=63.1-min-static-data-1 |
| sed -i'' -e '/^#/!s/SOURCE.*=.*txt/SOURCE = da.txt de.txt en.txt eo.txt es.txt fi.txt fr.txt he.txt id.txt it.txt ko.txt my.txt nl.txt pl.txt pt.txt pt_PT.txt ro.txt ru.txt sv.txt tr.txt uk.txt vi.txt zh.txt zh_Hans.txt/g' $l | ||
| # if its misc we need a couple of things | ||
| elif [ $(echo $l | grep -cF "misc") -eq 1 ]; then | ||
| sed -i'' -e '/^#/!s/SOURCE.*=.*txt/SOURCE = plurals.txt numberingSystems.txt icuver.txt icustd.txt pluralRanges.txt/g' $l |
Contributor
There was a problem hiding this comment.
wow, nice work figuring this out 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a slight mistake in the last PR for this library. It was missing one key data file that allows the library to properly choose the plural/singlar form for units when doing unit formatting. Other than that this is a copy of the previous package.