enable single peer connection as default#94
Merged
xianshijing-lk merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
alan-george-lk
approved these changes
Apr 14, 2026
| // for both publishing and subscribing instead of two separate connections. | ||
| // Falls back to dual peer connection if the server doesn't support single PC. | ||
| bool single_peer_connection = false; | ||
| bool single_peer_connection = true; |
Contributor
There was a problem hiding this comment.
Is this technically a breaking change?
Collaborator
Author
There was a problem hiding this comment.
No, it is just using different implementation for signaling.
Our developers should not notice any difference except for a smaller connection latency
xianshijing-lk
deleted the
sxian/enable_single_peer_connection_as_default
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.