Data tracks throughput#111
Open
stephen-derosa wants to merge 1 commit intolivekit:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a data-track throughput benchmarking experiment (producer/consumer executables + plotting tooling) and updates repo docs/ignores to support running it.
Changes:
- Add
benchmarks/data_track_throughputstandalone CMake project with producer/consumer executables that coordinate via RPC and write raw CSV measurements. - Add Python post-processing script to generate throughput/latency plots from the CSV output.
- Update documentation and
.gitignoreentries for Docker build notes and benchmark output directories.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| include/livekit/data_track_subscription.h | Introduces a new public header for a blocking data-track subscription type. |
| benchmarks/data_track_throughput/producer.cpp | Producer benchmark executable that publishes a data track and runs scenario sweeps/single scenario. |
| benchmarks/data_track_throughput/consumer.cpp | Consumer benchmark executable that records arrivals, validates headers, and writes CSVs. |
| benchmarks/data_track_throughput/common.h | Shared scenario planning, payload/header encoding, CSV helpers, and validation. |
| benchmarks/data_track_throughput/scripts/plot_throughput.py | CSV ingestion + derived metrics + plot generation. |
| benchmarks/data_track_throughput/scripts/.gitignore | Ignores venv/pycache artifacts for the plotting scripts. |
| benchmarks/data_track_throughput/README.md | Documents benchmark design, bounds, and usage/plot outputs. |
| benchmarks/data_track_throughput/CMakeLists.txt | Standalone build for benchmark + dependency fetching and library copying. |
| README.md | Updates Docker build instructions to use base + sdk Dockerfiles. |
| .gitignore | Ignores benchmark output directory data_track_throughput_results/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stephen-derosa
force-pushed
the
sderosa/data_tracks_throughput
branch
2 times, most recently
from
b86d39a to
9258ade
Compare
stephen-derosa
force-pushed
the
sderosa/data_tracks_throughput
branch
from
889271d to
467cb37
Compare
stephen-derosa
force-pushed
the
sderosa/data_tracks_throughput
branch
from
467cb37 to
2ec3a7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
benchmark/data_track_throughput: throughput executables and post processing tooling for visualizing Data Track MBPS throughput