Rename BestBlock to BlockLocator#4576
Rename BestBlock to BlockLocator#4576TheBlueMatt wants to merge 1 commit intolightningdevkit:mainfrom
BestBlock to BlockLocator#4576Conversation
|
I've assigned @valentinewallace as a reviewer! |
| @@ -372,7 +372,7 @@ impl<'a, L: chain::Listen + ?Sized> ChainNotifier<'a, L> { | |||
| /// Updates the header cache as it goes, tracking headers needed to find the diff to reuse for | |||
| /// other objects that might need similar headers. | |||
| async fn find_difference_from_best_block<P: Poll>( | |||
There was a problem hiding this comment.
Nit: The method name find_difference_from_best_block still references the old BestBlock name while its parameter type has been changed to BlockLocator. Consider renaming to find_difference_from_block_locator for consistency with the rest of the rename.
|
The rename is thorough — no remaining references to the No new issues found beyond my prior review comment on Review SummaryNo new issues found. The Prior inline comment (still applicable):
Observations (non-blocking, for maintainer awareness):
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4576 +/- ##
=======================================
Coverage 87.08% 87.09%
=======================================
Files 161 161
Lines 109255 109246 -9
Branches 109255 109246 -9
=======================================
- Hits 95147 95146 -1
+ Misses 11627 11623 -4
+ Partials 2481 2477 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tnull
left a comment
There was a problem hiding this comment.
Needs rustfmt, otherwise LGTM
`BestBlock` is now really a pointer to a block rather than just a block itself, so its weird to still call it `BestBlock`. Here we rename it to `BlockLocator`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5a6e9cb to
dcba68d
Compare
|
|
BestBlockis now really a pointer to a block rather than just a block itself, so its weird to still call itBestBlock. Here we rename it toBlockLocator.