Support sending PaymentMetadata in HTLCs#2127
Merged
TheBlueMatt merged 15 commits intolightningdevkit:mainfrom Apr 19, 2023
Merged
Support sending PaymentMetadata in HTLCs#2127TheBlueMatt merged 15 commits intolightningdevkit:mainfrom
PaymentMetadata in HTLCs#2127TheBlueMatt merged 15 commits intolightningdevkit:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds all the required infrastructure to send
PaymentMetadatain HTLCs, largely as a rebase of #1445 (with commit ordering shuffled around so that the new struct is added first - I ended up rewriting that commit as it makes sense to go first, rather than strictly rebasing the existing work).While this does deserialize the new field in the onion, it doesn't actually store it as HTLCs are received and expose it to users.
By switching the payment secret public API parameters to a new struct we also have more space to grow when we add the ability to have custom TLVs in the onion.