Applying consistant formatting across the project#1097
Applying consistant formatting across the project#1097nulltoken merged 1 commit intolibgit2:vNextfrom whoisj:ocd-cleanup
Conversation
whoisj
changed the title
|
/CC @nulltoken (sorry this is so huge - I swear there are no logical changes) |
There was a problem hiding this comment.
The spacing between the braces is a tad strange in this file.
|
@whoisj My head hurts a little bit, now 😉 Few questions:
|
|
@nulltoken this was all done by hand, with loving care ❤️. There's likely to be rather little PR collisions outside of a few files, and those collisions will be trivial to resolve (I've been testing against a few random PR which are pending). So yes, I'm willing to help with confict resolves and manage crowd hate (as I think there will actually be very little). 🙏 |
Wow! You're astonishing... We somehow really need to automate this kind of process, later. /cc @shiftkey |
I think it's worth looking at repurposing CodeFormatter to suit - I did this for one of my projects, and aside from the VS2015 requirement it's pretty great. |
|
There are always tools like AStyle which are useful and do not require pre-release versions of Visual Studio to work. 😄 |
|
Is Travis on vacation today ? 🍹 |
|
This is what Astyle produces: |
|
@shiftkey I attempted to evaluate Octokit, but I can't even get the solution to load correctly let alone build or run. Could you set something up like I have for Astyle? 🙏 |
|
This is what Code Formatter produces |
Could this be due to the VS2015 requirement? I've held off on merging this PR into Octokit proper until it RTMs because of this... |
I'm using VS2015, but I get this fun error about needing to "click on the project and choose download", but that's not an option. 😞 |
|
@whoisj weird, haven't seen that one before. could you open an issue over on the repo with some details so I can look into it when I get a chance? |
|
Given the difficulties Octokit is having due to VS migration, and the semi-ugliness Astyle creates, do we want to just merge this PR? |
|
Many PRs will become unmergeable, but sure. /me silently curses this PR. |
@whoisj Could you fix in |
Cleaning up white space usage Cleaning up `using` statements Cleaning up `cref` usage Cleaning up parameter alignment Cleaning up brace positioning
@nulltoken done. 😀 |
Applying consistant formatting across the project
|
🎉 🎈 🍰 |
|
Thanks to you for having crafted this ❤️ |
4 participants
Attempting to clean up and standardize the formatting of the code in the project.
Looks very disruptive, but contains no logic changes.