pg_test_timing: Show additional TSC clock source debug info#76
Open
lfittl wants to merge 1 commit into
Open
Conversation
In some cases its necessary to understand whether TSC frequency data was sourced from CPUID, and which of the registers. Show this debug info at the end of pg_test_timing, and rework TSC functions to support that. This would have helped debug the buildfarm report fixed in 7fc36c5 and is likely going to aid in any TSC-related issues reported during the beta period or later. Additionally, emit a warning if TSC frequency from calibration differs by more than 10% from the TSC frequency in use, and suggest the use of timing_clock_source = 'system'. In passing, add an explicit early return in the output function if the loop count is zero. This can't happen in practice, but coverity complained because we unconditionally call output for the fast TSC measurement. Author: Lukas Fittl <lukas@fittl.com> Suggested-by: Andres Freund <andres@anarazel.de> Reviewed-by: Andres Freund <andres@anarazel.de> Reviewed-by: Haibo Yan <tristan.yim@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> (coverity fix only) Discussion: https://www.postgresql.org/message-id/flat/jr4hk2sxhqcfpb67ftz5g4vw33nm67cgf7go3wwmqsafu5aclq%405m67ukuhyszz#2fdfd95b6a4a74410196999818e16cfc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.