You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All clean — go build ./... and go vet ./... pass. No Go code changes, so no functional risk.
Review Summary
Clean, well-scoped docs PR. The commit message itself (docs: require Conventional Commits in CLAUDE.md) follows the convention it introduces — nice.
What's good:
Minimal change with clear intent
Correct placement — right after Workflow Preferences, before the heavier sections
Removing the green: example avoids a direct conflict with Conventional Commits
Two optional suggestions (posted as inline comments):
Line 12 — The Commit Messages section is quite terse for an AI-guidance file. Adding a brief example of the types/scopes used in this repo (e.g. feat:, fix:, docs:) would help Claude produce better messages without needing to fetch the spec each time.
Line 110 — TDD step 6 now says "commit the green state" with no format guidance. A small cross-reference to the new Commit Messages section would tie things together.
Neither is a blocker — the PR works as-is. LGTM with the optional nits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.mdstating that all commits follow the Conventional Commits specification.green: <what the test proves>example from the TDD loop's commit step so it no longer conflicts with the new convention.Test plan
CLAUDE.mdrenders correctly and the TDD list stays sequential (1-7).