Add start, end, start-ts and end-ts flags to log environment command#901
Conversation
|
Claude finished @FayeSGW's task in 2m 18s —— View job PR Review: Add start, end, start-ts and end-ts flags to log environment command
Static AnalysisAll checks pass:
Review SummaryThis is a clean, well-structured PR that follows existing codebase patterns closely. The changes add four new query parameters to the What's good:
Minor observations (non-blocking):
Verdict: This PR is ready to merge. It's a straightforward, well-scoped vertical slice that adds optional API parameters with appropriate tests. |
This PR adds --start and --end flags (for snapshot indices and time expressions), and --start-ts and --end-ts (for timestamps) to the kosli log env command.
This is to bring the command up to date with the latest version of the API endpoint, which has these optional parameters.