fix: fixes #128 chat without non-local repo.#131
Merged
knightedcodemonkey merged 2 commits intomainfrom May 3, 2026
Merged
Conversation
Owner
knightedcodemonkey
commented
May 3, 2026
- fixes Can’t use chat with local workspaces #128
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes issue #128 by keeping chat usable when switching to a local (repo-less) workspace, while a PAT and writable repository are already connected/selected.
Changes:
- Preserve the BYOT selected repository when applying a workspace record with no
repo(local workspace) so chat still has repository context. - Plumb a
getActiveWorkspaceDisplayLabelcallback into the Workspaces drawer to show the active workspace’s display label (PR title/head fallback) when rendering the active option. - Add a Playwright regression test covering “open local workspace after PAT connect → chat remains usable”.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/modules/workspace/workspaces-drawer/drawer.js | Allows overriding the active workspace’s option label via getActiveWorkspaceDisplayLabel. |
| src/modules/app-core/workspace-record-applied-handler.js | Stops clearing the selected repository preference when opening a repo-less workspace. |
| src/modules/app-core/github-workflows.js | Wires getActiveWorkspaceDisplayLabel through to the Workspaces drawer. |
| src/modules/app-core/github-workflows-setup.js | Pass-through for getActiveWorkspaceDisplayLabel into workflow initialization. |
| src/app.js | Adds getActiveWorkspaceDisplayLabel implementation based on persisted PR title/head (with UI fallbacks). |
| playwright/github-byot-ai.spec.ts | Adds regression test ensuring chat works after opening a local workspace with PAT connected. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.