Skip to content

fix: fixes #128 chat without non-local repo.#131

Merged
knightedcodemonkey merged 2 commits intomainfrom
bananas
May 3, 2026
Merged

fix: fixes #128 chat without non-local repo.#131
knightedcodemonkey merged 2 commits intomainfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Copy Markdown
Owner

Copilot AI review requested due to automatic review settings May 3, 2026 22:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes issue #128 by keeping chat usable when switching to a local (repo-less) workspace, while a PAT and writable repository are already connected/selected.

Changes:

  • Preserve the BYOT selected repository when applying a workspace record with no repo (local workspace) so chat still has repository context.
  • Plumb a getActiveWorkspaceDisplayLabel callback into the Workspaces drawer to show the active workspace’s display label (PR title/head fallback) when rendering the active option.
  • Add a Playwright regression test covering “open local workspace after PAT connect → chat remains usable”.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/modules/workspace/workspaces-drawer/drawer.js Allows overriding the active workspace’s option label via getActiveWorkspaceDisplayLabel.
src/modules/app-core/workspace-record-applied-handler.js Stops clearing the selected repository preference when opening a repo-less workspace.
src/modules/app-core/github-workflows.js Wires getActiveWorkspaceDisplayLabel through to the Workspaces drawer.
src/modules/app-core/github-workflows-setup.js Pass-through for getActiveWorkspaceDisplayLabel into workflow initialization.
src/app.js Adds getActiveWorkspaceDisplayLabel implementation based on persisted PR title/head (with UI fallbacks).
playwright/github-byot-ai.spec.ts Adds regression test ensuring chat works after opening a local workspace with PAT connected.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/modules/workspace/workspaces-drawer/drawer.js Outdated
@knightedcodemonkey knightedcodemonkey merged commit 314bf1a into main May 3, 2026
6 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch May 3, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can’t use chat with local workspaces

2 participants