fix: use canonicalize_axis function in reduce_shape function#21650
Merged
fchollet merged 4 commits intokeras-team:masterfrom Sep 15, 2025
Merged
fix: use canonicalize_axis function in reduce_shape function#21650fchollet merged 4 commits intokeras-team:masterfrom
fchollet merged 4 commits intokeras-team:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21650 +/- ##
=======================================
Coverage 82.55% 82.55%
=======================================
Files 571 571
Lines 57618 57646 +28
Branches 8999 9008 +9
=======================================
+ Hits 47564 47589 +25
- Misses 7759 7760 +1
- Partials 2295 2297 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fchollet
reviewed
Sep 10, 2025
Collaborator
fchollet
left a comment
fchollet
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please add a unit test for the fix.
Added unit test that does not pass without the change in operation_utils.py
Fixing the test, used the wrong axes
Contributor
Author
|
@fchollet , sure, added a test with multiple negative axes, but without keepdims. Let me know if you think more tests are needed. |
fchollet
approved these changes
Sep 15, 2025
google-ml-butler
bot
added
kokoro:force-run
ready to pull
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request to fix issue #21648