Fix SKLearnClassifier and SKLearnRegressor examples#21385
Merged
fchollet merged 7 commits intokeras-team:masterfrom Jun 17, 2025
Merged
Fix SKLearnClassifier and SKLearnRegressor examples#21385fchollet merged 7 commits intokeras-team:masterfrom
fchollet merged 7 commits intokeras-team:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21385 +/- ##
=======================================
Coverage 82.67% 82.67%
=======================================
Files 565 565
Lines 55064 55064
Branches 8569 8569
=======================================
Hits 45525 45525
Misses 7441 7441
Partials 2098 2098
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fchollet
approved these changes
Jun 17, 2025
Collaborator
fchollet
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The examples in the docstrings for
SKLearnClassifierandSKLearnRegressorare currently not working. This PR addresses the problems mentioned in, and closes #21384:keras.layersModelfromkeras.models[]SKLearnClassifierFix:SKLearnRegressorFix:linearactivation because it is a regression problem that does not fall between[0, 1]