Skip to content

Fix api_docs for to_ordinal#17485

Merged
copybara-service[bot] merged 3 commits intokeras-team:masterfrom
awsaf49:to_ordinal
Jan 27, 2023
Merged

Fix api_docs for to_ordinal#17485
copybara-service[bot] merged 3 commits intokeras-team:masterfrom
awsaf49:to_ordinal

Conversation

@awsaf49
Copy link
Copy Markdown
Contributor

@awsaf49 awsaf49 commented Jan 27, 2023

This PR will resolve two issues and add an explanation for to_ordinal utility, recently merged in #17419.

It will,

  1. Resolve a grammatical error in Return
  2. Resolve abnormality in api_docs due to a new line in the docstring. api_docs link
  3. Add a little explanation for to_ordinal

cc: @haifeng-jin

Copy link
Copy Markdown
Contributor

@haifeng-jin haifeng-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jan 27, 2023
@awsaf49
Copy link
Copy Markdown
Contributor Author

awsaf49 commented Jan 27, 2023

Thanks for the PR!

Glad to contribute :)

copybara-service bot pushed a commit that referenced this pull request Jan 27, 2023
Imported from GitHub PR #17485

This PR will resolve two issues and add an explanation for `to_ordinal` utility, recently merged in #17419.

It will,
1. Resolve a grammatical error in `Return`
2. Resolve abnormality in api_docs due to a new line in the docstring. [api_docs link](https://www.tensorflow.org/api_docs/python/tf/keras/utils/to_ordinal) <img src="https://user-images.githubusercontent.com/36858976/215018234-4e7b424d-c6df-4baf-89ba-cc561314578f.png" width=300>
3. Add a little explanation for `to_ordinal`

cc: @haifeng-jin
Copybara import of the project:

--
db1ec98 by Awsaf <awsaf49@gmail.com>:

fix grammar

--
bc8929c by Awsaf <awsaf49@gmail.com>:

fix for newline in api_docs]

new line creates abnormality in api_docs in https://www.tensorflow.org/api_docs/python/tf/keras/utils/to_ordinal
--
3ab1d2e by Awsaf <awsaf49@gmail.com>:

add little explanation

Merging this change closes #17485

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17485 from awsaf49:to_ordinal 3ab1d2e
PiperOrigin-RevId: 505141352
@copybara-service copybara-service bot merged commit a1ffe7e into keras-team:master Jan 27, 2023
@awsaf49 awsaf49 deleted the to_ordinal branch January 30, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull Ready to be merged into the codebase size:S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants