Added identity layer#17291
Merged
copybara-service[bot] merged 2 commits intokeras-team:masterfrom Dec 5, 2022
Merged
Conversation
Closed
google-ml-butler
bot
added
kokoro:force-run
ready to pull
Contributor
Author
|
Resolved the CI build error. Please run the workflow again. |
google-ml-butler
bot
added
the
keras-team-review-pending
google-ml-butler
bot
removed
the
ready to pull
fchollet
approved these changes
Dec 1, 2022
google-ml-butler
bot
added
kokoro:force-run
ready to pull
fchollet
removed
the
keras-team-review-pending
Contributor
Author
|
Not sure what's causing the build to fail. Here's the error: All tests failed with this error. |
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Dec 5, 2022
Imported from GitHub PR keras-team/keras#17291 @fchollet Please see #17251. Copybara import of the project: -- 356eaa8a7b035dcac2a565f9dde38201334f1c0c by Aditya Kane <64411306+AdityaKane2001@users.noreply.github.com>: Added identity layer -- b8240ece60fced29c0e47970219c064bed18ae83 by Aditya Kane <adityakane1@gmail.com>: added identity to core import Merging this change closes #17291 PiperOrigin-RevId: 492867838
Collaborator
|
Just an FYI: I have merged the PR, but it turned out to break a Google test for unknown reasons (seems related to the fact that some users created their own |
Collaborator
|
I have re-applied the change. One modification I had to do is to apply a |
Contributor
Author
|
@fchollet Thanks a lot for the follow up. Really nice of you to keep me in the loop. Thoroughly appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fchollet
Please see #17251.