Skip to content

Fix error when labels contains brackets when plotting model#16739

Merged
copybara-service[bot] merged 3 commits intokeras-team:masterfrom
cBournhonesque:cb/fix-bracket-viz
Jul 12, 2022
Merged

Fix error when labels contains brackets when plotting model#16739
copybara-service[bot] merged 3 commits intokeras-team:masterfrom
cBournhonesque:cb/fix-bracket-viz

Conversation

@cBournhonesque
Copy link
Copy Markdown

Relevant issue: keras-team/tf-keras#647

@google-cla
Copy link
Copy Markdown

google-cla bot commented Jun 30, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gbaned gbaned requested a review from fchollet July 1, 2022 15:13
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Jul 1, 2022
Copy link
Copy Markdown
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jul 4, 2022
@fchollet
Copy link
Copy Markdown
Collaborator

fchollet commented Jul 4, 2022

Please fix code formatting (apply black formatting to the edited files).

@fchollet fchollet removed ready to pull Ready to be merged into the codebase keras-team-review-pending Pending review by a Keras team member. labels Jul 4, 2022
@gbaned
Copy link
Copy Markdown
Collaborator

gbaned commented Jul 8, 2022

@cBournhonesque Can you please check @fchollet's comments and keep us posted ? Thank you!

@cBournhonesque
Copy link
Copy Markdown
Author

Sorry, missed that. Sure, applied sh shell/format.sh !

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jul 8, 2022
@copybara-service copybara-service bot merged commit e631d78 into keras-team:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull Ready to be merged into the codebase size:S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants