Cherrypick for RandomContrast update#16435
Merged
qlzh727 merged 6 commits intokeras-team:r2.9from Apr 18, 2022
Merged
Conversation
PiperOrigin-RevId: 438858608
This is one test file failing, due to the monkey patching happens in the dtensor.init(), and I will need to dig more about the root cause (probably due to patching tf.Variable with DVariable, and cause logic difference for instance type checking.) PiperOrigin-RevId: 439676157
1. Add docstring for LayoutMap. 2. Hide certain methods for keras.dtensor.optimizers. PiperOrigin-RevId: 442651549
PiperOrigin-RevId: 439938098
google-ml-butler
bot
added
the
keras-team-review-pending
Contributor
|
Weird CI Is failing. Any idea why? |
Member
Author
|
The CI failing was expected, since the CI build was configured to test against tf-nightly, and we didn't cherrypick the fix on keras master branch to r2.9. The same test will be run again when we make the release package. |
qlzh727
removed
the
keras-team-review-pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Piper cl: 439938098