Fix selfhosted Helm secret key collisions that broke GitLab PAT auth#431
Open
Copilot wants to merge 2 commits into
Open
Fix selfhosted Helm secret key collisions that broke GitLab PAT auth#431Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/jetstack/version-checker/sessions/b4159bd0-5f27-41a8-9cbe-f384acd99ab6 Co-authored-by: davidcollom <1504448+davidcollom@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix GitLab selfhosted PATs not working
Fix selfhosted Helm secret key collisions that broke GitLab PAT auth
May 9, 2026
davidcollom
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selfhosted GitLab PATs configured via Helm were not being used when
ca_path/insecurewere also set. In the generated Secret, those fields were written to thetokenkey, overwriting the PAT and causing registry auth failures.Helm template fix (selfhosted secret keys)
templates/secret.yaml:selfhosted.<name>.insecurenow storesinsecureselfhosted.<name>.ca_pathnow storesca_pathselfhosted.<name>.token.Regression coverage
tests/secret_test.yamlfor a selfhosted entry with:token(GitLab-style PAT)insecureca_path