Skip to content

Implemented UPM support and proper edge color support#14

Open
popcron wants to merge 20 commits into
jean-moreno:masterfrom
popcron:master
Open

Implemented UPM support and proper edge color support#14
popcron wants to merge 20 commits into
jean-moreno:masterfrom
popcron:master

Conversation

@popcron
Copy link
Copy Markdown

@popcron popcron commented Mar 10, 2019

The file structure was changed to allow the entire repository to be loaded into Unity via UPM with this single line into the manifest.json file:

"com.popcron.pp-edge-detection": "https://github.com/popcron/pp-edge-detection.git"

Classes were categorized into the correct namespace to follow consistency with the rest of the post processing effects. As such, to access the effect, you have to declare the namespace expliclity:

using UnityEngine.PostProcessing.Rendering;
...
if (profile.TryGetSettings(out EdgeDetect_BeforeTransparent edgeDetect))
{
    edgeDetect.enabled.Override(true);
}

The other change was to implement proper edge colour support for all edge detection modes. As showcased in this video.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants