Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release publishing pipeline to use npm OIDC trusted publishing (with provenance) for GitHub Release-triggered publishes, reducing reliance on long-lived npm credentials, and documents the updated release flow.
Changes:
- Add
id-token: writeand publish with--provenancefor release-triggered npm publishes (OIDC trusted publishing). - Keep
workflow_dispatchpublishing viaNPM_TOKEN(without provenance) and document the split behavior. - Start tracking Rust
Cargo.lockfiles by updating.gitignoreand committing lockfiles for the runtime and analysis guest.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/publish.yml |
Enables OIDC trusted publishing and provenance for release-triggered npm publishes; keeps token-based fallback for manual dispatch. |
docs/RELEASING.md |
Documents the new trusted publishing setup/prerequisites and clarifies the manual fallback path. |
CHANGELOG.md |
Adds an Unreleased entry describing the publishing change. |
.gitignore |
Stops ignoring Cargo.lock (and runtime lockfile), allowing Rust lockfiles to be committed. |
src/sandbox/runtime/Cargo.lock |
New committed Rust dependency lockfile for the sandbox runtime workspace. |
src/code-validator/guest/Cargo.lock |
New committed Rust dependency lockfile for the code-validator guest workspace. |
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Remove Cargo.lock from .gitignore and track lock files for both Rust workspaces (code-validator/guest and sandbox/runtime). Prevents transitive dependency MSRV breakage (e.g. constant_time_eq 0.4.3 requiring rustc 1.95.0) when building on CI with pinned toolchain versions.
simongdavies
force-pushed
the
use-trusted-publishing
branch
from
2e85028 to
8e9dee1
Compare
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the npm publishing workflow to use OIDC trusted publishing with provenance for release-triggered publishes, enhancing security by removing the need for a long-lived
NPM_TOKENsecret. Manual publishes viaworkflow_dispatchstill fall back toNPM_TOKEN. Documentation has been updated to explain these changes and the new publishing process.