[ENH] Add LightGBM Experiment integration#238
[ENH] Add LightGBM Experiment integration#238SimonBlanke merged 13 commits intohyperactive-project:mainfrom
Conversation
SimonBlanke
left a comment
There was a problem hiding this comment.
fix the code quality errors
|
Fixed the errors. Thanks!! |
SimonBlanke
left a comment
There was a problem hiding this comment.
please consider the checklist. Since this is a new feature this PR must also add documentation: https://github.com/hyperactive-project/Hyperactive/tree/main/docs
and possibly tests. Look into how estimators are tested in this package.
08199ef to
16e7b4f
Compare
|
@SimonBlanke I have updated the docs and added the tests. Thanks!! |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
SimonBlanke
left a comment
There was a problem hiding this comment.
I did some smaller fixes. The rest looks good.
Description
Adds LightGBM support to Hyperactive by introducing a LightGBMExperiment class that wraps the existing SklearnCvExperiment class
Related Issues
Related to #228
Type of Change
[BUG]- Bug fix (non-breaking change fixing an issue)[ENH]- New feature (non-breaking change adding functionality)[DOC]- Documentation changes[MNT]- MaintenanceHow was this solved?
Checklist
[BUG],[ENH],[DOC]or[MNT]make check(lint, format, isort)Testing
Additional Notes